From mboxrd@z Thu Jan 1 00:00:00 1970 From: IT Superhack To: development@lists.ipfire.org Subject: Re: Sending in patches Date: Fri, 15 Jan 2016 09:07:43 +0100 Message-ID: <5698A8CF.8090901@web.de> In-Reply-To: <1452821143.5665.79.camel@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2640424970701644246==" List-Id: --===============2640424970701644246== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hello Michael, Michael Tremer: > Hi, > > so about half a week has passed since my initial email. I suppose this > is all that is coming and that the others are perfectly satisfied with > this process. > > So let's conclude: > > On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote: >> On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer >> wrote: >> >>> I find this process with "git send-email" very easy and I am >>> not sure where the problems could be. >> >> I am using TortoiseGit with Windows 7. I don't know if this tool >> supports >> "git send-email" and I wouldn't want to use command line git (it is >> annoying to use more than one tool for the same job, IMHO). > > > I didn't know that this many people use Windows. The problem with that > is you cannot build the distribution. You can copy some files back and > forth, but never build. > > I consider this to be a huge disadvantage. > > Is this just by choice or did you not want to go through the trouble > setting up a Linux system? > >> Therefore, I >> create a patch file using TortoiseGit (I need a workflow reminder for >> this >> to get it right), then send the contents with Thunderbird where I >> have to >> remember to disable line wrap (also using a workflow reminder text). > > When ever you make personal notes, why not use the wiki for that and > share? Many other people might have the same questions. I recently wrote a page about sending in patches via a Mail User Agent. It can be found here: https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias Fischer here who sent me a good hint about disabling line-wrapping in TB.) > >> In other projects (using Github), IMHO it is much easier to push to >> one's >> own repository and create a merge request to the upstream repository. > > > We can't use GitHub. I have explained that at various occasions and > this thread wasn't started to discuss other tools. Other things have > been proposed, too, and the same goes for them. > > At the end the only problem I understand you are experiencing here is > actually emailing the patch files without your mail agents not making > garbage out of that. This can't be too hard to get right. > >> Discussion can take place with that merge request. > > No, not at all. This process is actually well thought through and > designed to maximise participation of the users and make everything > easy for developers. And I actually think it does that well. For me, sending in patches is not a very big issue since you only need to "set up" a system for sending in patches once. The problem is more the workflow after a patch has been sent in. Some of them seem to be dropped silently, while others are commented and then somehow forgotten. Perhaps I need to polish my english skills in order to add better descriptions to my patches... ;-) > >> In case you are open to using other tools in place of Patchwork, what >> >> about Gitlab? > > Patchwork is just a view to the patches. My actual repository for that > is my inbox. > >> >> >> Lars > > -Michael > Best regards, Timmothy Wilson --===============2640424970701644246== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRRWNCQUVCQ2dBR0JRSldtS2pXQUFvSkVP eUxhMUM1RWF6clJHc0gvakQ0cGU5WUg3dXJzZS94MVBPOS9MT2EKM1p3K25EcndPdVhiZnZoVFhJ WjhMTlhmN0RTTlo4YWozRFNDdkt4a3lla0Q3VGhtQjJsK3pyTjJla2FRZmdhdgpRVU9CS2FobFJH Z3RSK0ZORWNrcUU2bFY0QWp1dHhQQUdpSUJRNWxaZjB3bXlodHcvNXpDamd6Y0xxbjBkek5FCjNr aVN0NDRFQzFERndIUHFwSEFhNWhSb0RUcnN3dTJPLzAzelo0ZDN1TU54clF4L2hhMS9kSkdLQjVV d0tVaWoKK0o4SHF4ZEpjdERzN01BbGg1T2h4enFtQnp3Rzk1NjMxa1J2cjgrN205YjRjcnptaFdk WXo2UjJDYXVmd2k0dApzeUk3cC90SkpSTGNCYmdibXlCd0FiYmNZVmJPTDNIaitYT3BCMXBnVHU5 V1F3MHpIditWejV6NkVuSmhxWlE9Cj10cENrCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============2640424970701644246==--