Re: [PATCH] dnsmasq 2.75: next patch... (No.50)

["R. W. Rodolico" <rodo@dailydata.net>]

[-- Attachment #1: Type: text/plain, Size: 4771 bytes --]

FYI, the build from 2016-01-16 (dnsmasq_275_2016_01_16) has not had an
issue on my router since I installed it. I am 99% sure I installed it on
16 jan. AND, it is using the non-preferred DNS servers 209.244.0.3 &
8.8.4.4. I'm going to go ahead and change them to something better now.

Rod

On 01/23/2016 06:00 AM, Matthias Fischer wrote:
> Hi,
> 
> On 21.01.2016 00:51, Michael Tremer wrote:
>> Hi,
>>
>> I don't think that this is just *your* problem.
>>
>> So far we have had random crashes of dnsmasq on random machines.
>> Sometimes that happens three times in a row within 10 minutes.
>> Sometimes that doesn't happen for a few months. We have had this with
>> many name servers. Some of which have been reported to "work better".
>> Some of which have been reported to work "worse". That also includes
>> 8.8.8.8 and the LWL name servers.
> 
> Thanks - I didn't know all of these details yet.
> 
>> So it is just you who is having the troubles more often than usual.
>> Maybe that will go away soon.
> 
> Keep your fingers crossed.
> 
>> I am not fully convinced that the type of server plays a big role in
>> here. It might be something like the timing of the replies, etc. What
>> leads me to that idea is that the crashes are usually not reproducible
>> by a single query that goes wrong.
> 
> Anyway, patch No.056 came out a few minute ago: Coffee was updated, I'm
> at it again, Devel is running.
> 
>> I can set up a recursor on the machine you set up for me. Just give it
>> an additional IP address and I will setup the resolver. I am
>> maintaining a few already, so this won't hurt at all.
>> ...
> 
> @interested_testers: ;-))
> One suggestion from me to make testing a bit easier, if you like, just
> tell me your thoughts about this procedure:
> 
> I'll try to keep the files at http://people.ipfire.org/~mfischer/ up to
> date as fast as possible. If anything goes wrong with the responsible
> 'dnsmasq'-version, look at my repository if there is an updated binary.
> Look for "dnsmasq_[VERSION]_[DATE_BUILT]. As always: if it makes sense
> for your test environment, feel free to grab it and continue testing.
> Perhaps this makes the whole a bit easier for you and me. Don't ask for
> the latest version, just grab it.
> 
> Having some consisting problems here, at last I'd like to ask:
> 
> With our 'dnsmasq'-lfs-config I always get the following two warnings
> during compiling. This doesnt' happen while compiling the *original'
> source!:
> 
> First:
> ***SNIP***
> ...
> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
> -DVERSION='"2.75"'            -c dnsmasq.c	
> dnsmasq.c: In function 'main':
> dnsmasq.c:922:7: warning: implicit declaration of function
> 'do_script_run' [-Wimplicit-function-declaration]
>        while (helper_buf_empty() && do_script_run(now));
>        ^
> dnsmasq.c:55:7: warning: unused variable 'did_bind' [-Wunused-variable]
>    int did_bind = 0;
>        ^
> dnsmasq.c:54:9: warning: unused variable 'bound_device' [-Wunused-variable]
>    char *bound_device = NULL;
>          ^
> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
> -DVERSION='"2.75"'            -c dhcp.c	
> ...
> ***SNAP***
> 
> Second:
> ***SNIP***
> ...
> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
> -DVERSION='"2.75"'            -c isc.c	
> isc.c: In function 'dhcp_lease_new':
> isc.c:40:3: warning: ignoring return value of 'asprintf', declared with
> attribute warn_unused_result [-Wunused-result]
>    asprintf(&lease->fqdn, "%s.%s", hostname, daemon->domain_suffix);
>    ^
> cc  -o dnsmasq cache.o rfc1035.o util.o option.o forward.o network.o
> dnsmasq.o dhcp.o lease.o rfc2131.o netlink.o dbus.o bpf.o helper.o
> tftp.o log.o conntrack.o dhcp6.o rfc3315.o dhcp-common.o outpacket.o
> radv.o slaac.o auth.o ipset.o domain.o dnssec.o blockdata.o tables.o
> loop.o inotify.o poll.o rrfilter.o edns0.o arp.o isc.o -lidn
> -lnettle -lhogweed   -lgmp
> ...
> ***SNAP***
> 
> Despite these warnings, the 'dnsmasq'-binary is usually built and is
> running fine (here). But I'd like to get rid of these warnings and don't
> know how (sorry, I'm no programmer). Asking in the 'dnsmasq'-list had no
> effect, I got no answers at all.
> 
> Does anyone in here has a clue?
> 
> Best,
> Matthias
> 

-- 
Rod Rodolico
Daily Data, Inc.
POB 140465
Dallas TX 75214-0465
214.827.2170
http://www.dailydata.net