Re: [PATCH] dnsmasq 2.75: next patch... (No.50)

[Matthias Fischer <matthias.fischer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3614 bytes --]

Hi,

On 05.02.2016 00:50, Michael Tremer wrote:
> Hi,
> 
> On Sat, 2016-01-23 at 13:00 +0100, Matthias Fischer wrote:
>> Anyway, patch No.056 came out a few minute ago: Coffee was updated,
>> I'm
>> at it again, Devel is running.
> 
> Will any of this be targeted to be included in C98?

Hard to say. The last posting from Rodolico (see above), using the build
from 2016-01-16 sounds good to me ("has not had an issue...since I
installed it"). Perhaps we got a grip on this, but its hard to tell for me.
The whole thing is still "under construction and testing", even the
patch from today (Fix breakage in ARP code...) looks important (to me).
But thats hard to judge. All I can say, every version didn't crash at
any time here. I'm still waiting for that. ;-)

>> First:
>> ***SNIP***
>> ...
>> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
>> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
>> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
>> -DVERSION='"2.75"'            -c dnsmasq.c	
>> dnsmasq.c: In function 'main':
>> dnsmasq.c:922:7: warning: implicit declaration of function
>> 'do_script_run' [-Wimplicit-function-declaration]
>>        while (helper_buf_empty() && do_script_run(now));
>>        ^
>> dnsmasq.c:55:7: warning: unused variable 'did_bind' [-Wunused-
>> variable]
>>    int did_bind = 0;
>>        ^
>> dnsmasq.c:54:9: warning: unused variable 'bound_device' [-Wunused-
>> variable]
>>    char *bound_device = NULL;
>>          ^
>> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
>> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
>> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
>> -DVERSION='"2.75"'            -c dhcp.c	
>> ...
>> ***SNAP***
> 
> Get in touch with Simon for this. It is nothing major. But good to
> point it out.

I did this before and got no answer. If I omit our lfs-adaptions and
switches, everythings running fine and without any compiling errors or
warnings, so I think it deals with our various options. I'll first try
to find out which option(s) exactly trigger these errors.

>> Second:
>> ***SNIP***
>> ...
>> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
>> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
>> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
>> -DVERSION='"2.75"'            -c isc.c	
>> isc.c: In function 'dhcp_lease_new':
>> isc.c:40:3: warning: ignoring return value of 'asprintf', declared
>> with
>> attribute warn_unused_result [-Wunused-result]
>>    asprintf(&lease->fqdn, "%s.%s", hostname, daemon->domain_suffix);
>>    ^
>> cc  -o dnsmasq cache.o rfc1035.o util.o option.o forward.o network.o
>> dnsmasq.o dhcp.o lease.o rfc2131.o netlink.o dbus.o bpf.o helper.o
>> tftp.o log.o conntrack.o dhcp6.o rfc3315.o dhcp-common.o outpacket.o
>> radv.o slaac.o auth.o ipset.o domain.o dnssec.o blockdata.o tables.o
>> loop.o inotify.o poll.o rrfilter.o edns0.o arp.o isc.o -lidn
>> -lnettle -lhogweed   -lgmp
>> ...
>> ***SNAP***
> 
> This is in my code. I made a patch for that:
> 
> http://git.ipfire.org/?p=people/ms/dnsmasq.git;a=commitdiff;h=bac82b4ff2f971a0227efb1a83f2b2bb1cd28764
> 
> You can also pull the entire branch from that repository to generate a
> recent patch against the latest development version.

I hope this was the right thing to do: I integrated this patch in the
existing 'dnsmasq-Add-support-to-read-ISC-DHCP-lease-file.patch'-file.
Warning is gone.

>> ...

Best,
Matthias