From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: rsync 3.2.0
Date: Thu, 25 Jun 2020 17:28:57 +0200
Message-ID: <56d13dd2-c24b-bfc4-ec5e-e32fdda6b4d4@ipfire.org>
In-Reply-To: <CD641D70-4AA4-4AE0-8168-EAB88198F831@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6238457811738392315=="
List-Id: <development.lists.ipfire.org>

--===============6238457811738392315==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On 25.06.2020 10:54, Michael Tremer wrote:
> Hi,
>=20
>> On 20 Jun 2020, at 16:09, Matthias Fischer <matthias.fischer(a)ipfire.org>=
 wrote:
>>=20
>> Hi,
>>=20
>> rsync 3.2.0 is out and I just had time...

In fact, I'm at 3.2.1. See below.

>> In order to use the new xxhash checksum support and zstd compression,
>> the corresponding kernel modules would need to be activated. Do we want
>> or need these?
>=20
> You won=E2=80=99t need kernel modules for this. You simply need the relevan=
t libraries.

Ok. I wasn't sure. I found some 'zstd's in the rootfiles and thought we
would need these.

> I have packaged those for IPFire 3 and they are easy to build and have no f=
urther dependencies. So I would recommend to at least add zstd.

I am at it.

> https://git.ipfire.org/?p=3Dipfire-3.x.git;a=3Dblob;f=3Drsync/rsync.nm;h=3D=
528dcfc0a377bc770a45a8f88af00079eb26dc93;hb=3Db40cdb8c182d8b4aa05c6e23cc67118=
c4aa4853c
> https://git.ipfire.org/?p=3Dipfire-3.x.git;a=3Dblob;f=3Dzstd/zstd.nm;h=3De5=
afd342b9ad2ae0c0f394116ef2dfddea670413;hb=3D8bcac5c8cda49b91fe68bef64c3ad975b=
80a43ca

Thats exactly what I needed - thanks - I'll take a look.

>=20
>>=20
>> For now, I disabled both with these configure options:
>>=20
>> ...
>> 	--disable-xxhash \
>> 	--disable-zstd
>> ...
>>=20
>> Do we want (would someone use) the new 'rsync-ssl'-script? On a firewall!?
>=20
> I tried to find out what this is useful for. It doesn=E2=80=99t harm us and=
 calls openssl. So I would just leave it in there.

Ok.

Please note:

'rsync 3.2.1' just came out. I'm testing - and working on 'zstd 1.4.5'
(weekend, I think).

If you want, we could skip 3.2.0 =3D> no need to merge this patch.

I could mark 3.2.0 as 'superseded' in patchwork and we'll go straight to
3.2.1.

Opinions?

Best,
Matthias

--===============6238457811738392315==--