From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2 07/11] Drop intltool add-on
Date: Thu, 20 May 2021 15:14:49 +0100 [thread overview]
Message-ID: <57B3DD3F-07E0-442E-BDF3-7BE122DDC3FE@ipfire.org> (raw)
In-Reply-To: <359420e5-3f73-49a3-358b-db77e072ac24@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 6382 bytes --]
Hello,
This package was obviously available in the build environment.
There was just no need to package it and ship it as an add-on.
-Michael
> On 20 May 2021, at 15:13, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Hello Michael,
>
> thanks for your reply.
>
> I am a bit puzzled by it: Yes, I would have expected us to need intltool for building packages
> - but only in the toolchain. If I understood you correctly, we used to rely on an add-on for
> building core packages? That would be - um - interesting. :-)
>
> If so, do we have more candidates such as intltool?
I don’t know. Do you want to have a look? :)
>
> Thanks, and best regards,
> Peter Müller
>
>
>> Hello,
>>
>> We need this as a build dependency of probably a hundred packages :)
>>
>> I will keep this and move it into the core system.
>>
>> -Michael
>>
>>> On 17 May 2021, at 22:57, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>
>>> As discussed in https://wiki.ipfire.org/devel/telco/2021-05-03.
>>>
>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>> ---
>>> config/rootfiles/packages/intltool | 13 -----
>>> lfs/intltool | 85 ------------------------------
>>> make.sh | 1 -
>>> 3 files changed, 99 deletions(-)
>>> delete mode 100644 config/rootfiles/packages/intltool
>>> delete mode 100644 lfs/intltool
>>>
>>> diff --git a/config/rootfiles/packages/intltool b/config/rootfiles/packages/intltool
>>> deleted file mode 100644
>>> index e1421fad7..000000000
>>> --- a/config/rootfiles/packages/intltool
>>> +++ /dev/null
>>> @@ -1,13 +0,0 @@
>>> -usr/bin/intltool-extract
>>> -usr/bin/intltool-merge
>>> -usr/bin/intltool-prepare
>>> -usr/bin/intltool-update
>>> -usr/bin/intltoolize
>>> -#usr/share/aclocal/intltool.m4
>>> -#usr/share/intltool
>>> -#usr/share/intltool/Makefile.in.in
>>> -#usr/share/man/man8/intltool-extract.8
>>> -#usr/share/man/man8/intltool-merge.8
>>> -#usr/share/man/man8/intltool-prepare.8
>>> -#usr/share/man/man8/intltool-update.8
>>> -#usr/share/man/man8/intltoolize.8
>>> diff --git a/lfs/intltool b/lfs/intltool
>>> deleted file mode 100644
>>> index 234262f62..000000000
>>> --- a/lfs/intltool
>>> +++ /dev/null
>>> @@ -1,85 +0,0 @@
>>> -###############################################################################
>>> -# #
>>> -# IPFire.org - A linux based firewall #
>>> -# Copyright (C) 2007-2018 IPFire Team <info(a)ipfire.org> #
>>> -# #
>>> -# This program is free software: you can redistribute it and/or modify #
>>> -# it under the terms of the GNU General Public License as published by #
>>> -# the Free Software Foundation, either version 3 of the License, or #
>>> -# (at your option) any later version. #
>>> -# #
>>> -# This program is distributed in the hope that it will be useful, #
>>> -# but WITHOUT ANY WARRANTY; without even the implied warranty of #
>>> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the #
>>> -# GNU General Public License for more details. #
>>> -# #
>>> -# You should have received a copy of the GNU General Public License #
>>> -# along with this program. If not, see <http://www.gnu.org/licenses/>. #
>>> -# #
>>> -###############################################################################
>>> -
>>> -###############################################################################
>>> -# Definitions
>>> -###############################################################################
>>> -
>>> -include Config
>>> -
>>> -VER = 0.40.5
>>> -
>>> -THISAPP = intltool-$(VER)
>>> -DL_FILE = $(THISAPP).tar.bz2
>>> -DL_FROM = $(URL_IPFIRE)
>>> -DIR_APP = $(DIR_SRC)/$(THISAPP)
>>> -TARGET = $(DIR_INFO)/$(THISAPP)
>>> -PROG = intltool
>>> -PAK_VER = 1
>>> -
>>> -DEPS =
>>> -
>>> -###############################################################################
>>> -# Top-level Rules
>>> -###############################################################################
>>> -
>>> -objects = $(DL_FILE)
>>> -
>>> -$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>> -
>>> -$(DL_FILE)_MD5 = 3e7ded6f50d88cf8b8bb505eaf591775
>>> -
>>> -install : $(TARGET)
>>> -
>>> -check : $(patsubst %,$(DIR_CHK)/%,$(objects))
>>> -
>>> -download :$(patsubst %,$(DIR_DL)/%,$(objects))
>>> -
>>> -md5 : $(subst %,%_MD5,$(objects))
>>> -
>>> -
>>> -###############################################################################
>>> -# Downloading, checking, md5sum
>>> -###############################################################################
>>> -
>>> -$(patsubst %,$(DIR_CHK)/%,$(objects)) :
>>> - @$(CHECK)
>>> -
>>> -$(patsubst %,$(DIR_DL)/%,$(objects)) :
>>> - @$(LOAD)
>>> -
>>> -$(subst %,%_MD5,$(objects)) :
>>> - @$(MD5)
>>> -
>>> -dist:
>>> - @$(PAK)
>>> -
>>> -###############################################################################
>>> -# Installation Details
>>> -###############################################################################
>>> -
>>> -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>>> - @$(PREBUILD)
>>> - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar jxf $(DIR_DL)/$(DL_FILE)
>>> - cd $(DIR_APP) && ./configure --prefix=/usr
>>> - cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE)
>>> - cd $(DIR_APP) && make install
>>> - @rm -rf $(DIR_APP)
>>> - @$(POSTBUILD)
>>> diff --git a/make.sh b/make.sh
>>> index 3bca46d8f..56c93fb79 100755
>>> --- a/make.sh
>>> +++ b/make.sh
>>> @@ -1385,7 +1385,6 @@ buildipfire() {
>>> lfsmake2 openvpn
>>> lfsmake2 mpage
>>> lfsmake2 dbus
>>> - lfsmake2 intltool
>>> lfsmake2 libdaemon
>>> lfsmake2 avahi
>>> lfsmake2 cups
>>> --
>>> 2.26.2
>>
prev parent reply other threads:[~2021-05-20 14:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 21:55 [PATCH v2 00/11] Drop unmaintained or orphaned add-ons and packages, first batch Peter Müller
2021-05-17 21:55 ` [PATCH v2 01/11] Drop motion add-on Peter Müller
2021-05-17 21:56 ` [PATCH v2 02/11] Drop orphaned dependency add-on libmicrohttpd Peter Müller
2021-05-17 21:56 ` [PATCH v2 03/11] Drop Asterisk add-on Peter Müller
2021-05-17 21:56 ` [PATCH v2 04/11] Drop orphaned dependency "libsrtp" Peter Müller
2021-05-17 21:57 ` [PATCH v2 05/11] Zut alors, delete motion initiscript as well :-/ Peter Müller
2021-05-17 21:57 ` [PATCH v2 06/11] Drop SANE add-on Peter Müller
2021-05-17 21:57 ` [PATCH v2 07/11] Drop intltool add-on Peter Müller
2021-05-17 21:58 ` [PATCH v2 08/11] Drop miniupnpd add-on Peter Müller
2021-05-17 21:58 ` [PATCH v2 09/11] Drop fbset Peter Müller
2021-05-17 21:58 ` [PATCH v2 10/11] Drop sendEmail add-on Peter Müller
2021-05-17 21:59 ` [PATCH v2 11/11] make.sh: Do no longer build fbset and sendEmail Peter Müller
2021-05-20 9:36 ` [PATCH v2 07/11] Drop intltool add-on Michael Tremer
2021-05-20 14:13 ` Peter Müller
2021-05-20 14:14 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B3DD3F-07E0-442E-BDF3-7BE122DDC3FE@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox