From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Problems trying to update lua-5.4.3 Date: Fri, 16 Apr 2021 21:56:57 +0200 Message-ID: <58f6d42e-122a-70ec-e624-a24a3abdc326@ipfire.org> In-Reply-To: <7032B9FE-5078-4467-9C72-79EE8A4D011F@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9133111045952864301==" List-Id: --===============9133111045952864301== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 14/04/2021 20:02, Michael Tremer wrote: > Hello, >=20 >> On 14 Apr 2021, at 13:33, Adolf Belka wrote: >> >> Hallo, >> >> On 14/04/2021 11:08, Michael Tremer wrote: >>> Hello, >>> I think you can use this as inspiration: >>> http://www.linuxfromscratch.org/blfs/view/svn/general/lua.html >>> The patch should already be updated and should be working. >> The patch there is the shared_library-1.patch >> >> I can certainly use it in my build but the patch I was having the question= s about is the autotoolize.patch This is not mentioned in the Beyond Linux F= rom Scratch link. Also not in the BLFS link for the previous version of lua-5= .3.4 >> >> Searching I have found that this patch is designed to have the lua build u= se the standard autotools programs. However the locations in Fedora and other= repositories I found seem to stop at lua-5.3.0 >=20 > Apart from Fedora, it is worth checking Gentoo because they are usually ver= y up to date and should have patches. Archlinux is a good option, too, becaus= e they keep their patches to a minimum and are a rolling release as well. I checked Gentoo but they also seemed to have stopped at 5.3.1 Arch Linux have followed the BLFS process and have not autotoolized lua. >=20 >> Any help with where to find a newer version of the autotoolize.patch that = is meant for lua-5.4.3 >=20 > If there is none available, we can just use the steps without configure lik= e BLFS. So in the end I followed the BLFS process and it built successfully. One thing I noticed is that the old rootfile had the plain .so library uncomm= ented and the .so.5.3 library commented out. This is the opposite of what is = normally done. Is this correct for lua? Should I follow the same process for = 5.4.3 or should I change it? Regards, Adolf. >=20 > -Michael >=20 >> >> Regards, >> >> Adolf >>> -Michael >>>> On 13 Apr 2021, at 22:06, Adolf Belka wrote: >>>> >>>> Hi All, >>>> >>>> >>>> I have been working on updating lua from 5.3.5 to 5.4.3 >>>> >>>> I updated the autotoolize.patch and the shared_library-1.patch and found= that 5.4.3 no longer has lbitlib.c in the tarball src directory >>>> >>>> >>>> I removed lbitlib.c from the liblua_la_SOURCES section in the diff for l= ua-5.3.5/src/Makefile.am >>>> >>>> ----------------------------------------------------------- >>>> +AM_CFLAGS =3D -Wall >>>> + >>>> +include_HEADERS =3D lua.h lualib.h lauxlib.h lua.hpp >>>> + >>>> +nodist_include_HEADERS =3D luaconf.h >>>> + >>>> +lib_LTLIBRARIES =3D liblua.la >>>> +liblua_la_LDFLAGS =3D -release @MAJOR_VERSION@ >>>> +liblua_la_SOURCES =3D \ >>>> + lapi.c lauxlib.c lbaselib.c lbitlib.c lcode.c lcorolib.c lctype.c l= dblib.c \ >>>> + ldebug.c ldo.c ldump.c lfunc.c lgc.c linit.c liolib.c llex.c lmathl= ib.c lmem.c \ >>>> + loadlib.c lobject.c lopcodes.c loslib.c lparser.c lstate.c lstring.= c lstrlib.c \ >>>> + ltable.c ltablib.c ltm.c lundump.c lutf8lib.c lvm.c lzio.c \ >>>> + lapi.h lcode.h lctype.h ldebug.h ldo.h lfunc.h lgc.h llex.h llimits= .h \ >>>> + lmem.h lobject.h lopcodes.h lparser.h lstate.h lstring.h ltable.h l= tm.h \ >>>> + lundump.h lvm.h lzio.h >>>> + >>>> >>>> ----------------------------------------------------------- >>>> >>>> and then lua built without any problems. >>>> >>>> >>>> So lua built successfully but looking at the files in the tarball src di= rectory for 5.3.5 & 5.4.3 there are some differences >>>> >>>> The following files >>>> lua.c >>>> luac.c >>>> lua.h >>>> luaconf.h >>>> lualib.h >>>> lauxlib.h >>>> lprefix.h >>>> >>>> are in both 5.3.5 & 5.4.3 but not in the liblua_la_SOURCES section. This= may be deliberate, I can't tell. >>>> >>>> However lbitlib.c is in 5.3.5 & liblua_la_SOURCES but not in 5.4.3 Is t= hat a problem for IPFire's use of lua? >>>> >>>> >>>> ljumptab.h and lopnames.h are not in 5.3.5 or liblua_la_SOURCES but are = in 5.4.3 Should these now be included somewhere in the Makefile.am or elsewh= ere or is it OK to ignore them for IPFire? >>>> >>>> >>>> Regards, >>>> >>>> Adolf. >>>> >=20 --===============9133111045952864301==--