From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Start local and uplink network independent Date: Wed, 24 May 2023 09:59:35 +0100 Message-ID: <5912CCFF-CAEC-4156-AC8F-11E50ED95616@ipfire.org> In-Reply-To: <20230523172314.7826-1-jonatan.schlag@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8537039138447857957==" List-Id: --===============8537039138447857957== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Jonatan, Thanks for this *huge* patchset. What I do not quite understand from your email is the motivation for this. St= arting the SSH daemon a little bit sooner is not justifying such massive chan= ge. I consider this a highly risky patchset as we are touching code that is alrea= dy incredibly fragile and the smallest changes might introduce more problems. But I have to say that I like how you split this into small patches that can = be reviewed easier. > On 23 May 2023, at 18:23, Jonatan Schlag wrot= e: >=20 > Hi, >=20 > this is the first try for a patch series which makes the startup of local a= nd uplink networks independent. This resolves in the end #11502. It should fu= rther allow us to keep waiting for a DHCP lease, because at least our local n= etworks are all up when we get to the red network. This might have some small= quirks, even when my testing so far shows no problems. I still think it is n= ow better to share result, then to wait any longer. > As this touches quite important parts of our network stack, I might be a co= uld idea to merge this in two stages. After the patch, titled "network startu= p: Clean up duplicated Code ", might be a good breaking point. But in the en= d, this is up to you. Please keep in mind, I only tested the full patch set: >=20 > Remove ipsec interface creation from network startup > Remove Start/Stop links for client175 > Use bash as shebang in network initscripts > network initscripts: check if the zone in the current config exists > network initscripts: Remove code for old zone scheme > network scripts: remove check for AUTOCONNECT > network startup: Reload routing informations for every interface > network startup: Always cleanup before red gets started > network startup: check for correct action at start > network startup: Refactor how cmd args are processed > network startup: Clean up duplicated Code > network script: add extra scripts for action that depend on a network > network startup: Add scripts for local and uplink > network startup: Start local and uplink network independent > network startup: Only work with configured zones >=20 > config/rootfiles/common/aarch64/initscripts | 31 +++-- > config/rootfiles/common/riscv64/initscripts | 31 +++-- > config/rootfiles/common/x86_64/initscripts | 31 +++-- > lfs/initscripts | 36 +++--- > src/initscripts/networking/any | 31 ++++- > src/initscripts/networking/functions.network | 14 +- > src/initscripts/networking/red | 5 +- > .../networking/red.up/99-pakfire-update | 2 +- > src/initscripts/system/depends-on-network | 40 ++++++ > src/initscripts/system/network | 121 ++++++++---------- > 10 files changed, 218 insertions(+), 124 deletions(-) > create mode 100644 src/initscripts/system/depends-on-network >=20 >=20 > Looking forward to your feedback >=20 > Greetings > Jonatan >=20 --===============8537039138447857957==--