Re: [PATCH] ddns.cgi: Drop static provider list for token based auth.

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

Hello,

I do not understand exactly what this patch is trying to achieve.

Unfortunately we have no choice than doing it this way with the current UI.

I do not think it is worth altering the UI for this, and I do not know how we could do it without having a list again?

-Michael

> On 2 Dec 2020, at 11:30, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
> 
> This is really hard to maintain when adding new or altering existing
> providers.
> 
> Reference #12415.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> html/cgi-bin/ddns.cgi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/html/cgi-bin/ddns.cgi b/html/cgi-bin/ddns.cgi
> index 715c37290..024eaf7f6 100644
> --- a/html/cgi-bin/ddns.cgi
> +++ b/html/cgi-bin/ddns.cgi
> @@ -665,13 +665,13 @@ sub GenerateDDNSConfigFile {
> 
> 		my $use_token = 0;
> 
> -		# Handle token based auth for various providers.
> -		if ($provider ~~ ["dns.lightningwirelabs.com", "entrydns.net", "regfish.com",
> -				  "spdns.de", "zzzz.io"] && $username eq "token") {
> +		# Check if token based auth is configured.
> +		if ($username eq "token") {
> 			$use_token = 1;
> +		}
> 
> 		# Handle token auth for freedns.afraid.org and regfish.com.
> -		} elsif ($provider ~~ ["freedns.afraid.org", "regfish.com"] && $password eq "") {
> +		if ($provider ~~ ["freedns.afraid.org", "regfish.com"] && $password eq "") {
> 			$use_token = 1;
> 			$password = $username;
> 
> -- 
> 2.20.1
>