From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ddns.cgi: Drop static provider list for token based auth.
Date: Wed, 02 Dec 2020 14:55:18 +0000
Message-ID: <59E63519-84C3-40AF-8A77-DEC92FBAFBB8@ipfire.org>
In-Reply-To: <20201202113011.5382-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3751047851401030379=="
List-Id: <development.lists.ipfire.org>

--===============3751047851401030379==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

I do not understand exactly what this patch is trying to achieve.

Unfortunately we have no choice than doing it this way with the current UI.

I do not think it is worth altering the UI for this, and I do not know how we=
 could do it without having a list again?

-Michael

> On 2 Dec 2020, at 11:30, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
>=20
> This is really hard to maintain when adding new or altering existing
> providers.
>=20
> Reference #12415.
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> html/cgi-bin/ddns.cgi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/html/cgi-bin/ddns.cgi b/html/cgi-bin/ddns.cgi
> index 715c37290..024eaf7f6 100644
> --- a/html/cgi-bin/ddns.cgi
> +++ b/html/cgi-bin/ddns.cgi
> @@ -665,13 +665,13 @@ sub GenerateDDNSConfigFile {
>=20
> 		my $use_token =3D 0;
>=20
> -		# Handle token based auth for various providers.
> -		if ($provider ~~ ["dns.lightningwirelabs.com", "entrydns.net", "regfish.=
com",
> -				  "spdns.de", "zzzz.io"] && $username eq "token") {
> +		# Check if token based auth is configured.
> +		if ($username eq "token") {
> 			$use_token =3D 1;
> +		}
>=20
> 		# Handle token auth for freedns.afraid.org and regfish.com.
> -		} elsif ($provider ~~ ["freedns.afraid.org", "regfish.com"] && $password=
 eq "") {
> +		if ($provider ~~ ["freedns.afraid.org", "regfish.com"] && $password eq "=
") {
> 			$use_token =3D 1;
> 			$password =3D $username;
>=20
> --=20
> 2.20.1
>=20


--===============3751047851401030379==--