suricata: error in 'convert-ids-modifysids-file' -

suricata: error in 'convert-ids-modifysids-file' -

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi,

being curious I tested the latest changes for 'suricata' from current
'next' and ran into the following error:

***SNIP***
root(a)ipfire: /usr # /usr/sbin/convert-ids-modifysids-file
Global symbol "%idssettings" requires explicit package name at
/usr/sbin/convert-ids-modifysids-file line 57.
Execution of /usr/sbin/convert-ids-modifysids-file aborted due to
compilation errors.
***SNAP***

Adding "my %idssettings=();" in line 27 seemed to fix this.

Could someone please check and confirm?

Best,
Matthias

Re: suricata: error in 'convert-ids-modifysids-file' -

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Hello Matthias,

thanks for pointing this out.

I'll send a patch to fix this issue, as soon as possible.

Best regards,

-Stefan
> Hi,
> 
> being curious I tested the latest changes for 'suricata' from current
> 'next' and ran into the following error:
> 
> ***SNIP***
> root(a)ipfire: /usr # /usr/sbin/convert-ids-modifysids-file
> Global symbol "%idssettings" requires explicit package name at
> /usr/sbin/convert-ids-modifysids-file line 57.
> Execution of /usr/sbin/convert-ids-modifysids-file aborted due to
> compilation errors.
> ***SNAP***
> 
> Adding "my %idssettings=();" in line 27 seemed to fix this.
> 
> Could someone please check and confirm?
> 
> Best,
> Matthias

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH] convert-ids-modifysids-file: Fix check if the ids is running.

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 config/suricata/convert-ids-modifysids-file | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/suricata/convert-ids-modifysids-file b/config/suricata/convert-ids-modifysids-file
index adcc10577..f1c2a7b9c 100644
--- a/config/suricata/convert-ids-modifysids-file
+++ b/config/suricata/convert-ids-modifysids-file
@@ -54,7 +54,7 @@ if (-f $IDS::rulestarball) {
 #
 
 # Check if the IDS should be started.
-if($idssettings{"ENABLE_IDS"} eq "on") {
+if(&IDS::ids_is_running()) {
 	# Call suricatactrl and reload the rules.
 	&IDS::call_suricatactrl("reload");
 }
-- 
2.20.1

Re: suricata: error in 'convert-ids-modifysids-file' -

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

Great catch!

I like it when we find problems before we branch the release :) Well done guys!

-Michael

> On 9 Jun 2019, at 16:53, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
> 
> Hello Matthias,
> 
> thanks for pointing this out.
> 
> I'll send a patch to fix this issue, as soon as possible.
> 
> Best regards,
> 
> -Stefan
>> Hi,
>> 
>> being curious I tested the latest changes for 'suricata' from current
>> 'next' and ran into the following error:
>> 
>> ***SNIP***
>> root(a)ipfire: /usr # /usr/sbin/convert-ids-modifysids-file
>> Global symbol "%idssettings" requires explicit package name at
>> /usr/sbin/convert-ids-modifysids-file line 57.
>> Execution of /usr/sbin/convert-ids-modifysids-file aborted due to
>> compilation errors.
>> ***SNAP***
>> 
>> Adding "my %idssettings=();" in line 27 seemed to fix this.
>> 
>> Could someone please check and confirm?
>> 
>> Best,
>> Matthias