From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] wlanap.cgi: Cosmetic fix - replace 'Save' image with
 'Save' button
Date: Mon, 28 Dec 2020 14:20:33 +0100
Message-ID: <5B388EF2-F7E2-4C61-9BF0-19800C7B83FD@ipfire.org>
In-Reply-To: <20201227154801.6788-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6864148426114792277=="
List-Id: <development.lists.ipfire.org>

--===============6864148426114792277==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 27 Dec 2020, at 16:48, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> The 'WLanAP'-GUI is the only page where settings are saved by clicking
> an unlabeled floppy disk image.
>=20
> Why? I don't know - this image is otherwise only used by the 'Backup'-GUI
> to save settings.
>=20
> Now replaced by the standard 'Save' button.
>=20
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/wlanap.cgi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/html/cgi-bin/wlanap.cgi b/html/cgi-bin/wlanap.cgi
> index fd7e9a679..cfdcac576 100644
> --- a/html/cgi-bin/wlanap.cgi
> +++ b/html/cgi-bin/wlanap.cgi
> @@ -516,8 +516,7 @@ print <<END
> <table width=3D'80%' cellspacing=3D'0'>
> <tr><td align=3D'center'>
> <form method=3D'post' action=3D'$ENV{'SCRIPT_NAME'}'>
> -       <input type=3D'hidden' name=3D'ACTION' value=3D$Lang::tr{'save'} />
> -       <input type=3D'image' alt=3D'$Lang::tr{'save'}' title=3D'$Lang::tr{=
'save'}' src=3D'/images/media-floppy.png' /></form></td>
> +       <input type=3D'submit' name=3D'ACTION' value=3D$Lang::tr{'save'} />=
</form></td>

This is invalid syntax because =E2=80=9Cvalue=E2=80=9D is not quoted. Some HT=
ML parsers do not care, but this would break if =E2=80=9Csave=E2=80=9D would =
be longer than one word in one language.

-Michael

> </tr>
> </table>
> END
> --=20
> 2.18.0
>=20


--===============6864148426114792277==--