Re: [PATCH 4/4] graphs.pl: use brackets instead of hypens

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 27 Apr 2020, at 16:25, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> This simply makes more sense in most languages, as INPUT, OUTPUT and
> FORWARD are special cases of firewall hits in general.
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/cfgroot/graphs.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/config/cfgroot/graphs.pl b/config/cfgroot/graphs.pl
> index 872e9bd7c..7b056d117 100644
> --- a/config/cfgroot/graphs.pl
> +++ b/config/cfgroot/graphs.pl
> @@ -683,17 +683,17 @@ sub updatefwhitsgraph {
> 		"COMMENT:".sprintf("%15s",$Lang::tr{'average'}),
> 		"COMMENT:".sprintf("%14s",$Lang::tr{'minimal'}),
> 		"COMMENT:".sprintf("%15s",$Lang::tr{'current'})."\\j",
> -		"AREA:output".$color{"color25"}."A0:".sprintf("%-25s",$Lang::tr{'firewallhits'}."-OUTPUT"),
> +		"AREA:output".$color{"color25"}."A0:".sprintf("%-25s",$Lang::tr{'firewallhits'}." (OUTPUT)"),
> 		"GPRINT:output:MAX:%8.1lf %sBps",
> 		"GPRINT:output:AVERAGE:%8.1lf %sBps",
> 		"GPRINT:output:MIN:%8.1lf %sBps",
> 		"GPRINT:output:LAST:%8.1lf %sBps\\j",
> -		"STACK:forward".$color{"color23"}."A0:".sprintf("%-25s",$Lang::tr{'firewallhits'}."-FORWARD"),
> +		"STACK:forward".$color{"color23"}."A0:".sprintf("%-25s",$Lang::tr{'firewallhits'}." (FORWARD)"),
> 		"GPRINT:forward:MAX:%8.1lf %sBps",
> 		"GPRINT:forward:AVERAGE:%8.1lf %sBps",
> 		"GPRINT:forward:MIN:%8.1lf %sBps",
> 		"GPRINT:forward:LAST:%8.1lf %sBps\\j",
> -		"STACK:input".$color{"color24"}."A0:".sprintf("%-25s",$Lang::tr{'firewallhits'}."-INPUT"),
> +		"STACK:input".$color{"color24"}."A0:".sprintf("%-25s",$Lang::tr{'firewallhits'}." (INPUT)"),
> 		"GPRINT:input:MAX:%8.1lf %sBps",
> 		"GPRINT:input:AVERAGE:%8.1lf %sBps",
> 		"GPRINT:input:MIN:%8.1lf %sBps",
> -- 
> 2.16.4