From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 4/4] graphs.pl: use brackets instead of hypens
Date: Mon, 27 Apr 2020 16:33:35 +0100
Message-ID: <5B69B7E0-539E-46DC-9B66-C0075A101429@ipfire.org>
In-Reply-To: <e822b5c2-a962-255d-d491-2ef586adbd3a@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6155890219068096576=="
List-Id: <development.lists.ipfire.org>

--===============6155890219068096576==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 27 Apr 2020, at 16:25, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> This simply makes more sense in most languages, as INPUT, OUTPUT and
> FORWARD are special cases of firewall hits in general.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/cfgroot/graphs.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/config/cfgroot/graphs.pl b/config/cfgroot/graphs.pl
> index 872e9bd7c..7b056d117 100644
> --- a/config/cfgroot/graphs.pl
> +++ b/config/cfgroot/graphs.pl
> @@ -683,17 +683,17 @@ sub updatefwhitsgraph {
> 		"COMMENT:".sprintf("%15s",$Lang::tr{'average'}),
> 		"COMMENT:".sprintf("%14s",$Lang::tr{'minimal'}),
> 		"COMMENT:".sprintf("%15s",$Lang::tr{'current'})."\\j",
> -		"AREA:output".$color{"color25"}."A0:".sprintf("%-25s",$Lang::tr{'firewal=
lhits'}."-OUTPUT"),
> +		"AREA:output".$color{"color25"}."A0:".sprintf("%-25s",$Lang::tr{'firewal=
lhits'}." (OUTPUT)"),
> 		"GPRINT:output:MAX:%8.1lf %sBps",
> 		"GPRINT:output:AVERAGE:%8.1lf %sBps",
> 		"GPRINT:output:MIN:%8.1lf %sBps",
> 		"GPRINT:output:LAST:%8.1lf %sBps\\j",
> -		"STACK:forward".$color{"color23"}."A0:".sprintf("%-25s",$Lang::tr{'firew=
allhits'}."-FORWARD"),
> +		"STACK:forward".$color{"color23"}."A0:".sprintf("%-25s",$Lang::tr{'firew=
allhits'}." (FORWARD)"),
> 		"GPRINT:forward:MAX:%8.1lf %sBps",
> 		"GPRINT:forward:AVERAGE:%8.1lf %sBps",
> 		"GPRINT:forward:MIN:%8.1lf %sBps",
> 		"GPRINT:forward:LAST:%8.1lf %sBps\\j",
> -		"STACK:input".$color{"color24"}."A0:".sprintf("%-25s",$Lang::tr{'firewal=
lhits'}."-INPUT"),
> +		"STACK:input".$color{"color24"}."A0:".sprintf("%-25s",$Lang::tr{'firewal=
lhits'}." (INPUT)"),
> 		"GPRINT:input:MAX:%8.1lf %sBps",
> 		"GPRINT:input:AVERAGE:%8.1lf %sBps",
> 		"GPRINT:input:MIN:%8.1lf %sBps",
> --=20
> 2.16.4


--===============6155890219068096576==--