From: Michael Tremer <michael.tremer@ipfire.org>
To: Stephen Cuka <stephen@firemypi.org>
Cc: development@lists.ipfire.org
Subject: Re: [PATCH] header.pl: Fixbug13857 - Disable Blue Access submenu if no BLUE network
Date: Wed, 28 May 2025 10:26:50 +0100 [thread overview]
Message-ID: <5BDEFB9E-6484-4A9D-B780-06C1325A3592@ipfire.org> (raw)
In-Reply-To: <20250528064223.1975817-1-stephen@firemypi.org>
Hello Stephen,
Good catch! This was broken since 2019.
https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=820b2909825479b52696886d1f9054c0f709d3f0
-Michael
> On 28 May 2025, at 07:42, Stephen Cuka <stephen@firemypi.org> wrote:
>
> - Fix reference to BlueAccess menu item so that it is disabled
> when BLUE network is not in use.
>
> Signed-off-by: Stephen Cuka <stephen@firemypi.org>
> ---
> config/cfgroot/header.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
> index 2d4aa89f2..1eb7e3b9a 100644
> --- a/config/cfgroot/header.pl
> +++ b/config/cfgroot/header.pl
> @@ -456,7 +456,7 @@ sub genmenu {
> eval `/bin/cat /var/ipfire/menu.d/*.main`;
>
> if (! blue_used()) {
> - $menu->{'05.firewall'}{'subMenu'}->{'60.wireless'}{'enabled'} = 0;
> + $menu->{'05.firewall'}{'subMenu'}->{'70.wireless'}{'enabled'} = 0;
> }
> if ( $Network::ethernet{'CONFIG_TYPE'} =~ /^(1|2|3|4)$/ && $Network::ethernet{'RED_TYPE'} eq 'STATIC' ) {
> $menu->{'03.network'}{'subMenu'}->{'70.aliases'}{'enabled'} = 1;
> --
> 2.43.0
>
>
prev parent reply other threads:[~2025-05-28 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 6:42 Stephen Cuka
2025-05-28 9:26 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BDEFB9E-6484-4A9D-B780-06C1325A3592@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
--cc=stephen@firemypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox