From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [RFC PATCH] linux: Remove user-space probe support
Date: Mon, 03 Oct 2022 10:48:16 +0100
Message-ID: <5E09EFF5-68AA-49F6-A232-13AEDD1E4233@ipfire.org>
In-Reply-To: <7c95e1cf-a4b7-23e1-379c-97aafd8d7783@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4543173429590430444=="
List-Id: <development.lists.ipfire.org>

--===============4543173429590430444==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

I would say, that we do not use this feature - or at least I don=E2=80=99t.

Did you check whether some other options depend on this?

-Michael

> On 2 Oct 2022, at 15:47, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wro=
te:
>=20
> From the kernels' documentation:
>=20
>> Uprobes is the user-space counterpart to kprobes: they
>> enable instrumentation applications (such as 'perf probe')
>> to establish unintrusive probes in user-space binaries and
>> libraries, by executing handler functions when the probes
>> are hit by user-space applications.
>>=20
>> ( These probes come in the form of single-byte breakpoints,
>> managed by the kernel and kept transparent to the probed
>> application. )
>=20
> To the best of the authors' understanding, no application on IPFire
> needs this functionality, and given its abuse potential, we should
> probably not enable it.
>=20
> As expected, strace functionality is not impaired by this.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/kernel/kernel.config.aarch64-ipfire | 5 +----
> config/kernel/kernel.config.armv6l-ipfire  | 5 +----
> config/kernel/kernel.config.x86_64-ipfire  | 5 +----
> 3 files changed, 3 insertions(+), 12 deletions(-)
>=20
> diff --git a/config/kernel/kernel.config.aarch64-ipfire b/config/kernel/ker=
nel.config.aarch64-ipfire
> index 836e2b15f..76dbafc5f 100644
> --- a/config/kernel/kernel.config.aarch64-ipfire
> +++ b/config/kernel/kernel.config.aarch64-ipfire
> @@ -645,7 +645,6 @@ CONFIG_CRYPTO_AES_ARM64_BS=3Dm
> # CONFIG_KPROBES is not set
> CONFIG_JUMP_LABEL=3Dy
> CONFIG_STATIC_KEYS_SELFTEST=3Dy
> -CONFIG_UPROBES=3Dy
> CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=3Dy
> CONFIG_HAVE_KPROBES=3Dy
> CONFIG_HAVE_KRETPROBES=3Dy
> @@ -8154,9 +8153,7 @@ CONFIG_TRACER_SNAPSHOT=3Dy
> CONFIG_BRANCH_PROFILE_NONE=3Dy
> # CONFIG_PROFILE_ANNOTATED_BRANCHES is not set
> # CONFIG_BLK_DEV_IO_TRACE is not set
> -CONFIG_UPROBE_EVENTS=3Dy
> -CONFIG_DYNAMIC_EVENTS=3Dy
> -CONFIG_PROBE_EVENTS=3Dy
> +# CONFIG_UPROBE_EVENTS is not set
> CONFIG_FTRACE_MCOUNT_RECORD=3Dy
> CONFIG_FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY=3Dy
> # CONFIG_SYNTH_EVENTS is not set
> diff --git a/config/kernel/kernel.config.armv6l-ipfire b/config/kernel/kern=
el.config.armv6l-ipfire
> index ae611fc6f..28f4ef3aa 100644
> --- a/config/kernel/kernel.config.armv6l-ipfire
> +++ b/config/kernel/kernel.config.armv6l-ipfire
> @@ -738,7 +738,6 @@ CONFIG_AS_VFP_VMRS_FPINST=3Dy
> # CONFIG_KPROBES is not set
> CONFIG_JUMP_LABEL=3Dy
> CONFIG_STATIC_KEYS_SELFTEST=3Dy
> -CONFIG_UPROBES=3Dy
> CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=3Dy
> CONFIG_ARCH_USE_BUILTIN_BSWAP=3Dy
> CONFIG_HAVE_KPROBES=3Dy
> @@ -8129,9 +8128,7 @@ CONFIG_BRANCH_PROFILE_NONE=3Dy
> # CONFIG_PROFILE_ANNOTATED_BRANCHES is not set
> # CONFIG_PROFILE_ALL_BRANCHES is not set
> # CONFIG_BLK_DEV_IO_TRACE is not set
> -CONFIG_UPROBE_EVENTS=3Dy
> -CONFIG_DYNAMIC_EVENTS=3Dy
> -CONFIG_PROBE_EVENTS=3Dy
> +# CONFIG_UPROBE_EVENTS is not set
> CONFIG_FTRACE_MCOUNT_RECORD=3Dy
> CONFIG_FTRACE_MCOUNT_USE_RECORDMCOUNT=3Dy
> # CONFIG_SYNTH_EVENTS is not set
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kern=
el.config.x86_64-ipfire
> index d005f98d4..bb4655a99 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -671,7 +671,6 @@ CONFIG_GENERIC_ENTRY=3Dy
> CONFIG_JUMP_LABEL=3Dy
> CONFIG_STATIC_KEYS_SELFTEST=3Dy
> # CONFIG_STATIC_CALL_SELFTEST is not set
> -CONFIG_UPROBES=3Dy
> CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=3Dy
> CONFIG_ARCH_USE_BUILTIN_BSWAP=3Dy
> CONFIG_USER_RETURN_NOTIFIER=3Dy
> @@ -7594,9 +7593,7 @@ CONFIG_TRACER_SNAPSHOT=3Dy
> CONFIG_BRANCH_PROFILE_NONE=3Dy
> # CONFIG_PROFILE_ANNOTATED_BRANCHES is not set
> # CONFIG_BLK_DEV_IO_TRACE is not set
> -CONFIG_UPROBE_EVENTS=3Dy
> -CONFIG_DYNAMIC_EVENTS=3Dy
> -CONFIG_PROBE_EVENTS=3Dy
> +# CONFIG_UPROBE_EVENTS is not set
> CONFIG_FTRACE_MCOUNT_RECORD=3Dy
> CONFIG_FTRACE_MCOUNT_USE_CC=3Dy
> # CONFIG_SYNTH_EVENTS is not set
> --=20
> 2.35.3


--===============4543173429590430444==--