From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] sendEmail 
Date: Thu, 14 Feb 2019 11:06:19 +0000
Message-ID: <5EE56D89-2358-48BB-9840-BA2F8C3B727A@ipfire.org>
In-Reply-To: <q426t7$k70$1@tuscan3.grantura.co.uk>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0328464750185501746=="
List-Id: <development.lists.ipfire.org>

--===============0328464750185501746==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Yes, this is almost it.

Two minor things (I fixed both of them for you):

* If you change an add-on, please increase PAK_VER. That way, pakfire knows t=
hat this package has changed.

* You used spaces instead of tabs for the indentation of the added line. GNU =
Make only supports tabs.

I merged the patch though.

Best,
-Michael

> On 13 Feb 2019, at 22:49, Rob Brewer <ipfire-devel(a)grantura.co.uk> wrote:
>=20
> Michael Tremer wrote:
>=20
>> Would you re-submit this patch with =E2=80=9Cgit send-email=E2=80=9D so th=
at Patchwork can
>> pick it up and it can be merged?
>>=20
> I'm still getting my head around git. Hopefully this is what is needed.
>=20
> HTH
>=20
> Rob
>=20
>=20
> diff --git a/lfs/sendEmail b/lfs/sendEmail
> index 28646ef93..cc9f67aaa 100644
> --- a/lfs/sendEmail
> +++ b/lfs/sendEmail
> @@ -63,6 +63,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>        @$(PREBUILD)
>        @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
>        cd $(DIR_APP) && cp -pvf sendEmail /usr/local/bin
> +       chown root.root /usr/local/bin/sendEmail
>        chmod 755 /usr/local/bin/sendEmail
>        @rm -rf $(DIR_APP)
>        @$(POSTBUILD)
>=20


--===============0328464750185501746==--