From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4gCKXj161yz2y6G for ; Sat, 09 May 2026 08:53:57 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [IPv6:2001:678:b28::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1 raw public key) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R12" (not verified)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4gCKXd5gH4z2xLm for ; Sat, 09 May 2026 08:53:53 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4gCKXc1Lxvz2q7; Sat, 09 May 2026 08:53:52 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1778316832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S3F4/sm+26iy8wlRAZZOMHaL08vxYQZ/3pCNHoLf8QA=; b=5a8QQf1tvwHj4O8b2UVDtVX2xL5bboPcwIYVmQ4+La/8tabSWldPT6tlzhXoW6AD7ySQco 2EV5bXbmzsXA6fAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1778316832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S3F4/sm+26iy8wlRAZZOMHaL08vxYQZ/3pCNHoLf8QA=; b=mb30mL8P6nnxr5uJrgDfx4A9gPT8tkh04SzBlO6RbnI4ZpKVNZ8xBksUJqxglwkVkQi15D CJm1dszgzmyJcXSg0BXf4It5evE2w09aMwB6oCspRS8T1bgecoR6naObNgwoFRZaeCIN26 9NsqG3lNEBGm11CrdjNKHM9KUjQVz8I7+vQJ6QueqZ+ovD+QxOrSg7eptQQCI6xaYFVROL CpnX2E9/5l7PFSKd+ItFLrC4yHeKxExF203qE0fMeUUUp7enMbK9Oww8HTCogCBiBbbU03 EsETaUCBgZkiVmzwn/qLRMukcSoOwYCp6v8RX+sr3FG7bz/JLfhQFemKHSWaIw== Content-Type: text/plain; charset=us-ascii Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH] for Bug 13967 - OpenVPN is missing a way to use "block-outside-dns" From: Michael Tremer In-Reply-To: <1778240422246.3723185779.1317300897@web.de> Date: Sat, 9 May 2026 09:53:50 +0100 Cc: development@lists.ipfire.org Content-Transfer-Encoding: quoted-printable Message-Id: <5F986D56-F518-42AD-AA95-D281837AF003@ipfire.org> References: <1778240422246.3723185779.1317300897@web.de> To: Larsen Hello Larsen, Thank you for your email. Please read through the guide on how to submit a patch: https://www.ipfire.org/docs/devel/submit-patches This patch has been mangled, you are missing a proper sender and Git = tags. Regrading the contents of this, you are implementing this as a global = option for all clients. All other options are implemented globally as = well as on a per-client basis so that they can be enabled only where = they are actually needed. Would you be able to add this? All the best, -Michael > On 8 May 2026, at 12:44, Larsen wrote: >=20 >=20 >=20 > @@ -, +, @@ html/cgi-bin/ovpnmain.cgi | 13 +++++++++++++ > langs/en/cgi-bin/en.pl | 1 + > 2 files changed, 14 insertions(+) > --- a/html/cgi-bin/ovpnmain.cgi=20 > +++ a/html/cgi-bin/ovpnmain.cgi=20 > @@ -388,6 +388,9 @@ sub writeserverconf { > print CONF "push \"dhcp-option WINS $wins_server\"\n"; > } > + if ($vpnsettings{BLOCK_OUTSIDE_DNS} eq 'on') { > + print CONF "push \"block-outside-dns\"\n"; > + } > if ($vpnsettings{MAX_CLIENTS} eq '') { > print CONF "max-clients 100\n"; > } > @@ -1098,6 +1101,7 @@ if ($cgiparams{'ACTION'} eq = $Lang::tr{'save-adv-options'}) { > $vpnsettings{'DHCP_DOMAIN'} =3D $cgiparams{'DHCP_DOMAIN'}; > $vpnsettings{'DHCP_DNS'} =3D $cgiparams{'DHCP_DNS'}; > $vpnsettings{'DHCP_WINS'} =3D $cgiparams{'DHCP_WINS'}; > + $vpnsettings{'BLOCK_OUTSIDE_DNS'} =3D = $cgiparams{'BLOCK_OUTSIDE_DNS'}; > $vpnsettings{'ROUTES_PUSH'} =3D $cgiparams{'ROUTES_PUSH'}; > $vpnsettings{'DATACIPHERS'} =3D $cgiparams{'DATACIPHERS'}; > $vpnsettings{'DCIPHER'} =3D $cgiparams{'DCIPHER'}; > @@ -2722,6 +2726,9 @@ ADV_ERROR: > $selected{'DPROTOCOL'}{'tcp'} =3D ''; > $selected{'DPROTOCOL'}{$vpnsettings{'DPROTOCOL'}} =3D 'SELECTED'; > + $checked{'BLOCK_OUTSIDE_DNS'}{'off'} =3D ''; > + $checked{'BLOCK_OUTSIDE_DNS'}{'on'} =3D ''; > + $checked{'BLOCK_OUTSIDE_DNS'}{$vpnsettings{'BLOCK_OUTSIDE_DNS'}} = =3D 'CHECKED'; > $checked{'REDIRECT_GW_DEF1'}{'off'} =3D ''; > $checked{'REDIRECT_GW_DEF1'}{'on'} =3D ''; > $checked{'REDIRECT_GW_DEF1'}{$vpnsettings{'REDIRECT_GW_DEF1'}} =3D = 'CHECKED'; > @@ -2936,6 +2943,12 @@ END > > > > + > + $Lang::tr{'ovpn block outside dns'} > + > + > + > + > >
$Lang::tr{'ovpn routing settings'}
> --- a/langs/en/cgi-bin/en.pl=20 > +++ a/langs/en/cgi-bin/en.pl=20 > @@ -2068,6 +2068,7 @@ 'override mtu' =3D> 'Override default MTU', > 'ovpn' =3D> 'OpenVPN', > 'ovpn add conf' =3D> 'Additional configuration', > +'ovpn block outside dns' =3D> 'Block outside DNS', > 'ovpn ciphers' =3D> 'Ciphers', > 'ovpn con stat' =3D> 'OpenVPN Connection Statistics', > 'ovpn config' =3D> 'OVPN-Config', >=20