From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] add ddns Provider key-systems.net
Date: Thu, 23 Jan 2020 11:54:43 +0100
Message-ID: <5b11bb718a977d69a7726185d8ef2ef095126ddc.camel@ipfire.org>
In-Reply-To: <74ACA093-C896-4CB7-895F-B90F40A9151B@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7512342814420336433=="
List-Id: <development.lists.ipfire.org>

--===============7512342814420336433==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Christof,

thanks for your Patch.

I've merged it and corrected the "extra new line" issue.

Because we currently porting DDNS to python3, I also did a required
change.

Best regards,

-Stefan
> Hey Christof,
>=20
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>=20
> > On 7 Jan 2020, at 16:35, Christof Weniger <ChristofWeniger(a)gmx.at>
> > wrote:
> >=20
> > Hi,
> >=20
> > sorry for the long delay. It's the time of the year,  where I think
> > it might be easier to just move in with the childrens doctor
> > instead of daily vists :-(
>=20
> That doesn=E2=80=99t sound good :(
>=20
> > Michael thank you for your pointers and reviews.
>=20
> The patch however does!
>=20
> There is an extra newline after the class, but I guess we can accept
> it.
>=20
> I will leave it for Stefan to merge.=20
>=20
> Thanks.
>=20
> -Michael
>=20
> >=20
> > ---
> > README                |  1 +
> > src/ddns/providers.py | 46
> > +++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 47 insertions(+)
> >=20
> > diff --git a/README b/README
> > index c75c448..b6decb3 100644
> > --- a/README
> > +++ b/README
> > @@ -72,6 +72,7 @@ SUPPORTED PROVIDERS:
> > 	inwx.com|de|at|ch|es
> > 	itsdns.de
> > 	joker.com
> > +	key-systems.net
> > 	loopia.se
> > 	myonlineportal.net
> > 	namecheap.com
> > diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> > index 661fbcc..666740e 100644
> > --- a/src/ddns/providers.py
> > +++ b/src/ddns/providers.py
> > @@ -1204,6 +1204,52 @@ class DDNSProviderJoker(DDNSProtocolDynDNS2,
> > DDNSProvider):
> > 		url =3D "https://svc.joker.com/nic/update"
> >=20
> >=20
> > +class DDNSProviderKEYSYSTEMS(DDNSProvider):
> > +	handle    =3D "key-systems.net"
> > +	name      =3D "dynamicdns.key-systems.net"
> > +	website   =3D "https://domaindiscount24.com/"
> > +	protocols =3D ("ipv4",)
> > +
> > +	# There are only information provided by the domaindiscount24
> > how to
> > +	# perform an update with HTTP APIs
> > +	# https://www.domaindiscount24.com/faq/dynamic-dns
> > +	# examples:=20
> > https://dynamicdns.key-systems.net/update.php?hostname=3Dhostname&passwor=
d=3Dpassword&ip=3Dauto
> > +	#          =20
> > https://dynamicdns.key-systems.net/update.php?hostname=3Dhostname&passwor=
d=3Dpassword&ip=3D213.x.x.x&mx=3D213.x.x.x
> > +
> > +	url =3D "https://dynamicdns.key-systems.net/update.php"
> > +	can_remove_records =3D False
> > +
> > +	def update_protocol(self, proto):
> > +		address =3D self.get_address(proto)
> > +		data =3D {
> > +			"hostname"      : self.hostname,
> > +			"password"      : self.password,
> > +			"ip"            : address,
> > +		}
> > +
> > +		# Send update to the server.
> > +		response =3D self.send_request(self.url, data=3Ddata)
> > +
> > +		# Get the full response message.
> > +		output =3D response.read()
> > +
> > +		# Handle success messages.
> > +		if "code =3D 200" in output:
> > +			return
> > +
> > +		# Handle error messages.
> > +		if "abuse prevention triggered" in output:
> > +			raise DDNSAbuseError
> > +		elif "invalid password" in output:
> > +			raise DDNSAuthenticationError
> > +		elif "Authorization failed" in output:
> > +			raise DDNSRequestError(_("Invalid hostname
> > specified"))
> > +
> > +		# If we got here, some other update error happened.
> > +		raise DDNSUpdateError
> > +
> > +
> > +
> > class DDNSProviderGoogle(DDNSProtocolDynDNS2, DDNSProvider):
> >         handle    =3D "domains.google.com"
> >         name      =3D "Google Domains"
> > --
> > 2.17.1
> >=20


--===============7512342814420336433==--