public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* [PATCH] rust: Cleanup/Drop unneeded modules
@ 2026-01-28 18:02 Stefan Schantl
  2026-01-28 18:05 ` Michael Tremer
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Schantl @ 2026-01-28 18:02 UTC (permalink / raw)
  To: development; +Cc: Stefan Schantl

suricata and clamav are shipping the required modules for building with
their source tarballs, therefore we do not need to package those modules
anymore and they safely can be dropped.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 make.sh | 62 ---------------------------------------------------------
 1 file changed, 62 deletions(-)

diff --git a/make.sh b/make.sh
index 205aba057..fd8dd310b 100755
--- a/make.sh
+++ b/make.sh
@@ -1594,15 +1594,12 @@ build_system() {
 	lfsmake2 linux-atm
 	lfsmake2 libqmi
 	lfsmake2 c-ares
-	lfsmake2 rust-dissimilar
 	lfsmake2 rust-cfg-if
 	lfsmake2 rust-libc
-	lfsmake2 rust-libc-0.2.108
 	lfsmake2 rust-windows-link
 	lfsmake2 rust-windows-sys
 	lfsmake2 rust-errno
 	lfsmake2 rust-anyhow
-	lfsmake2 rust-unicode-xid-0.2.1
 	lfsmake2 rust-unicode-xid
 	lfsmake2 rust-unicode-ident
 	lfsmake2 rust-proc-macro2
@@ -1610,13 +1607,7 @@ build_system() {
 	lfsmake2 rust-syn
 	lfsmake2 rust-prettyplease
 	lfsmake2 rust-id-arena
-	lfsmake2 rust-log-0.4.14
 	lfsmake2 rust-log
-	lfsmake2 rust-ucd-trie
-	lfsmake2 rust-pest
-	lfsmake2 rust-semver-parser-0.7.0
-	lfsmake2 rust-semver-parser
-	lfsmake2 rust-semver-0.9.0
 	lfsmake2 rust-semver
 	lfsmake2 rust-bitflags
 	lfsmake2 rust-allocator-api2
@@ -1624,10 +1615,8 @@ build_system() {
 	lfsmake2 rust-equivalent
 	lfsmake2 rust-hashbrown
 	lfsmake2 rust-indexmap
-	lfsmake2 rust-serde_derive-1.0.216
 	lfsmake2 rust-serde_derive
 	lfsmake2 rust-serde_core
-	lfsmake2 rust-serde-1.0.216
 	lfsmake2 rust-serde
 	lfsmake2 rust-memchr
 	lfsmake2 rust-itoa
@@ -1641,7 +1630,6 @@ build_system() {
 	lfsmake2 rust-simd-adler32
 	lfsmake2 rust-miniz_oxide
 	lfsmake2 rust-flate2
-	lfsmake2 rust-smallvec-1.8.0
 	lfsmake2 rust-smallvec
 	lfsmake2 rust-spdx
 	lfsmake2 rust-percent-encoding
@@ -1686,85 +1674,36 @@ build_system() {
 	lfsmake2 rust-wasip2
 	lfsmake2 rust-r-efi
 	lfsmake2 rust-getrandom
-	lfsmake2 rust-getrandom-0.2.4
-	lfsmake2 rust-typenum
 	lfsmake2 rust-version-check
-	lfsmake2 rust-generic-array
-	lfsmake2 rust-crypto-common
-	lfsmake2 rust-cipher
-	lfsmake2 rust-hex
 	lfsmake2 rust-syn-1.0.109
-	lfsmake2 rust-syn-2.0.90
-	lfsmake2 rust-home
 	lfsmake2 rust-lazy-static
 	lfsmake2 rust-aho-corasick
 	lfsmake2 rust-regex-syntax
 	lfsmake2 rust-regex
-	lfsmake2 rust-same-file
-	lfsmake2 rust-walkdir
-	lfsmake2 rust-dirs
-	lfsmake2 rust-toolchain_find
-	lfsmake2 rust-synstructure
-	lfsmake2 rust-block-buffer
-	lfsmake2 rust-digest
-	lfsmake2 rust-ppv-lite86
-	lfsmake2 rust-rand_core
-	lfsmake2 rust-rand_core-0.4.2
-	lfsmake2 rust-rand_core-0.3.1
-	lfsmake2 rust-rand_chacha
-	lfsmake2 rust-rand_hc
-	lfsmake2 rust-rand
-	lfsmake2 rust-rdrand
-	lfsmake2 rust-rand-0.4
-	lfsmake2 rust-log-0.4.14
-	lfsmake2 rust-num_cpus
-	lfsmake2 rust-crossbeam-utils
 	lfsmake2 rust-autocfg
-	lfsmake2 rust-memoffset
 	lfsmake2 rust-scopeguard
-	lfsmake2 rust-crossbeam-epoch
-	lfsmake2 rust-crossbeam-deque
-	lfsmake2 rust-either
-	lfsmake2 rust-crossbeam-channel
-	lfsmake2 rust-rayon-core
-	lfsmake2 rust-rayon
-	lfsmake2 rust-remove_dir_all
-	lfsmake2 rust-tempdir
-	lfsmake2 rust-glob
 	lfsmake2 rust-once_cell
-	lfsmake2 rust-once_cell-1.9.0
-	lfsmake2 rust-termcolor
 	lfsmake2 rust-serde_spanned
 	lfsmake2 rust-toml_datetime
 	lfsmake2 rust-winnow
 	lfsmake2 rust-toml_edit
 	lfsmake2 rust-toml
-	lfsmake2 rust-target-triple
-	lfsmake2 rust-trybuild
 	lfsmake2 rust-unindent
 	lfsmake2 rust-proc-macro-hack
-	lfsmake2 rust-indoc-impl
 	lfsmake2 rust-indoc-impl-0.3.6
-	lfsmake2 rust-indoc
 	lfsmake2 rust-indoc-0.3.6
 	lfsmake2 rust-instant
 	lfsmake2 rust-lock_api
 	lfsmake2 rust-parking_lot_core
 	lfsmake2 rust-parking_lot
 	lfsmake2 rust-paste-impl
-	lfsmake2 rust-paste
 	lfsmake2 rust-paste-0.1.18
-	lfsmake2 rust-ctor
-	lfsmake2 rust-ghost
-	lfsmake2 rust-inventory-impl
-	lfsmake2 rust-inventory
 	lfsmake2 rust-pyo3-build-config
 	lfsmake2 rust-pyo3-macros-backend
 	lfsmake2 rust-pyo3-macros
 	lfsmake2 rust-pyo3
 	lfsmake2 rust-num-traits
 	lfsmake2 rust-num-integer
-	lfsmake2 rust-num_threads
 	lfsmake2 rust-time
 	lfsmake2 rust-iana-time-zone
 	lfsmake2 rust-chrono
@@ -1775,7 +1714,6 @@ build_system() {
 	lfsmake2 rust-Inflector
 	lfsmake2 rust-ouroboros_macro
 	lfsmake2 rust-aliasable
-	lfsmake2 rust-stable_deref_trait
 	lfsmake2 rust-ouroboros
 	lfsmake2 rust-base64
 	lfsmake2 rust-pem
-- 
2.47.3



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rust: Cleanup/Drop unneeded modules
  2026-01-28 18:02 [PATCH] rust: Cleanup/Drop unneeded modules Stefan Schantl
@ 2026-01-28 18:05 ` Michael Tremer
  2026-01-28 18:38   ` Stefan Schantl
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Tremer @ 2026-01-28 18:05 UTC (permalink / raw)
  To: Stefan Schantl; +Cc: development

Thank you for this patch, but I believe you forgot to remove the LFS files.

> On 28 Jan 2026, at 18:02, Stefan Schantl <stefan.schantl@ipfire.org> wrote:
> 
> suricata and clamav are shipping the required modules for building with
> their source tarballs, therefore we do not need to package those modules
> anymore and they safely can be dropped.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
> ---
> make.sh | 62 ---------------------------------------------------------
> 1 file changed, 62 deletions(-)
> 
> diff --git a/make.sh b/make.sh
> index 205aba057..fd8dd310b 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1594,15 +1594,12 @@ build_system() {
> lfsmake2 linux-atm
> lfsmake2 libqmi
> lfsmake2 c-ares
> - lfsmake2 rust-dissimilar
> lfsmake2 rust-cfg-if
> lfsmake2 rust-libc
> - lfsmake2 rust-libc-0.2.108
> lfsmake2 rust-windows-link
> lfsmake2 rust-windows-sys
> lfsmake2 rust-errno
> lfsmake2 rust-anyhow
> - lfsmake2 rust-unicode-xid-0.2.1
> lfsmake2 rust-unicode-xid
> lfsmake2 rust-unicode-ident
> lfsmake2 rust-proc-macro2
> @@ -1610,13 +1607,7 @@ build_system() {
> lfsmake2 rust-syn
> lfsmake2 rust-prettyplease
> lfsmake2 rust-id-arena
> - lfsmake2 rust-log-0.4.14
> lfsmake2 rust-log
> - lfsmake2 rust-ucd-trie
> - lfsmake2 rust-pest
> - lfsmake2 rust-semver-parser-0.7.0
> - lfsmake2 rust-semver-parser
> - lfsmake2 rust-semver-0.9.0
> lfsmake2 rust-semver
> lfsmake2 rust-bitflags
> lfsmake2 rust-allocator-api2
> @@ -1624,10 +1615,8 @@ build_system() {
> lfsmake2 rust-equivalent
> lfsmake2 rust-hashbrown
> lfsmake2 rust-indexmap
> - lfsmake2 rust-serde_derive-1.0.216
> lfsmake2 rust-serde_derive
> lfsmake2 rust-serde_core
> - lfsmake2 rust-serde-1.0.216
> lfsmake2 rust-serde
> lfsmake2 rust-memchr
> lfsmake2 rust-itoa
> @@ -1641,7 +1630,6 @@ build_system() {
> lfsmake2 rust-simd-adler32
> lfsmake2 rust-miniz_oxide
> lfsmake2 rust-flate2
> - lfsmake2 rust-smallvec-1.8.0
> lfsmake2 rust-smallvec
> lfsmake2 rust-spdx
> lfsmake2 rust-percent-encoding
> @@ -1686,85 +1674,36 @@ build_system() {
> lfsmake2 rust-wasip2
> lfsmake2 rust-r-efi
> lfsmake2 rust-getrandom
> - lfsmake2 rust-getrandom-0.2.4
> - lfsmake2 rust-typenum
> lfsmake2 rust-version-check
> - lfsmake2 rust-generic-array
> - lfsmake2 rust-crypto-common
> - lfsmake2 rust-cipher
> - lfsmake2 rust-hex
> lfsmake2 rust-syn-1.0.109
> - lfsmake2 rust-syn-2.0.90
> - lfsmake2 rust-home
> lfsmake2 rust-lazy-static
> lfsmake2 rust-aho-corasick
> lfsmake2 rust-regex-syntax
> lfsmake2 rust-regex
> - lfsmake2 rust-same-file
> - lfsmake2 rust-walkdir
> - lfsmake2 rust-dirs
> - lfsmake2 rust-toolchain_find
> - lfsmake2 rust-synstructure
> - lfsmake2 rust-block-buffer
> - lfsmake2 rust-digest
> - lfsmake2 rust-ppv-lite86
> - lfsmake2 rust-rand_core
> - lfsmake2 rust-rand_core-0.4.2
> - lfsmake2 rust-rand_core-0.3.1
> - lfsmake2 rust-rand_chacha
> - lfsmake2 rust-rand_hc
> - lfsmake2 rust-rand
> - lfsmake2 rust-rdrand
> - lfsmake2 rust-rand-0.4
> - lfsmake2 rust-log-0.4.14
> - lfsmake2 rust-num_cpus
> - lfsmake2 rust-crossbeam-utils
> lfsmake2 rust-autocfg
> - lfsmake2 rust-memoffset
> lfsmake2 rust-scopeguard
> - lfsmake2 rust-crossbeam-epoch
> - lfsmake2 rust-crossbeam-deque
> - lfsmake2 rust-either
> - lfsmake2 rust-crossbeam-channel
> - lfsmake2 rust-rayon-core
> - lfsmake2 rust-rayon
> - lfsmake2 rust-remove_dir_all
> - lfsmake2 rust-tempdir
> - lfsmake2 rust-glob
> lfsmake2 rust-once_cell
> - lfsmake2 rust-once_cell-1.9.0
> - lfsmake2 rust-termcolor
> lfsmake2 rust-serde_spanned
> lfsmake2 rust-toml_datetime
> lfsmake2 rust-winnow
> lfsmake2 rust-toml_edit
> lfsmake2 rust-toml
> - lfsmake2 rust-target-triple
> - lfsmake2 rust-trybuild
> lfsmake2 rust-unindent
> lfsmake2 rust-proc-macro-hack
> - lfsmake2 rust-indoc-impl
> lfsmake2 rust-indoc-impl-0.3.6
> - lfsmake2 rust-indoc
> lfsmake2 rust-indoc-0.3.6
> lfsmake2 rust-instant
> lfsmake2 rust-lock_api
> lfsmake2 rust-parking_lot_core
> lfsmake2 rust-parking_lot
> lfsmake2 rust-paste-impl
> - lfsmake2 rust-paste
> lfsmake2 rust-paste-0.1.18
> - lfsmake2 rust-ctor
> - lfsmake2 rust-ghost
> - lfsmake2 rust-inventory-impl
> - lfsmake2 rust-inventory
> lfsmake2 rust-pyo3-build-config
> lfsmake2 rust-pyo3-macros-backend
> lfsmake2 rust-pyo3-macros
> lfsmake2 rust-pyo3
> lfsmake2 rust-num-traits
> lfsmake2 rust-num-integer
> - lfsmake2 rust-num_threads
> lfsmake2 rust-time
> lfsmake2 rust-iana-time-zone
> lfsmake2 rust-chrono
> @@ -1775,7 +1714,6 @@ build_system() {
> lfsmake2 rust-Inflector
> lfsmake2 rust-ouroboros_macro
> lfsmake2 rust-aliasable
> - lfsmake2 rust-stable_deref_trait
> lfsmake2 rust-ouroboros
> lfsmake2 rust-base64
> lfsmake2 rust-pem
> -- 
> 2.47.3
> 
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rust: Cleanup/Drop unneeded modules
  2026-01-28 18:05 ` Michael Tremer
@ 2026-01-28 18:38   ` Stefan Schantl
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Schantl @ 2026-01-28 18:38 UTC (permalink / raw)
  To: development

Hello Michael,

thanks for reviewing.

That was my bad, I didn't use "git rm" to remove the LFS and rootfiles
so they where not part of the commit.

So the patch only contained the make.sh changes.

I'll send a v2 patch.

Best regards,

-Stefan
> Thank you for this patch, but I believe you forgot to remove the LFS
> files.
> 
> > On 28 Jan 2026, at 18:02, Stefan Schantl
> > <stefan.schantl@ipfire.org> wrote:
> > 
> > suricata and clamav are shipping the required modules for building
> > with
> > their source tarballs, therefore we do not need to package those
> > modules
> > anymore and they safely can be dropped.
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
> > ---
> > make.sh | 62 ------------------------------------------------------
> > ---
> > 1 file changed, 62 deletions(-)
> > 
> > diff --git a/make.sh b/make.sh
> > index 205aba057..fd8dd310b 100755
> > --- a/make.sh
> > +++ b/make.sh
> > @@ -1594,15 +1594,12 @@ build_system() {
> > lfsmake2 linux-atm
> > lfsmake2 libqmi
> > lfsmake2 c-ares
> > - lfsmake2 rust-dissimilar
> > lfsmake2 rust-cfg-if
> > lfsmake2 rust-libc
> > - lfsmake2 rust-libc-0.2.108
> > lfsmake2 rust-windows-link
> > lfsmake2 rust-windows-sys
> > lfsmake2 rust-errno
> > lfsmake2 rust-anyhow
> > - lfsmake2 rust-unicode-xid-0.2.1
> > lfsmake2 rust-unicode-xid
> > lfsmake2 rust-unicode-ident
> > lfsmake2 rust-proc-macro2
> > @@ -1610,13 +1607,7 @@ build_system() {
> > lfsmake2 rust-syn
> > lfsmake2 rust-prettyplease
> > lfsmake2 rust-id-arena
> > - lfsmake2 rust-log-0.4.14
> > lfsmake2 rust-log
> > - lfsmake2 rust-ucd-trie
> > - lfsmake2 rust-pest
> > - lfsmake2 rust-semver-parser-0.7.0
> > - lfsmake2 rust-semver-parser
> > - lfsmake2 rust-semver-0.9.0
> > lfsmake2 rust-semver
> > lfsmake2 rust-bitflags
> > lfsmake2 rust-allocator-api2
> > @@ -1624,10 +1615,8 @@ build_system() {
> > lfsmake2 rust-equivalent
> > lfsmake2 rust-hashbrown
> > lfsmake2 rust-indexmap
> > - lfsmake2 rust-serde_derive-1.0.216
> > lfsmake2 rust-serde_derive
> > lfsmake2 rust-serde_core
> > - lfsmake2 rust-serde-1.0.216
> > lfsmake2 rust-serde
> > lfsmake2 rust-memchr
> > lfsmake2 rust-itoa
> > @@ -1641,7 +1630,6 @@ build_system() {
> > lfsmake2 rust-simd-adler32
> > lfsmake2 rust-miniz_oxide
> > lfsmake2 rust-flate2
> > - lfsmake2 rust-smallvec-1.8.0
> > lfsmake2 rust-smallvec
> > lfsmake2 rust-spdx
> > lfsmake2 rust-percent-encoding
> > @@ -1686,85 +1674,36 @@ build_system() {
> > lfsmake2 rust-wasip2
> > lfsmake2 rust-r-efi
> > lfsmake2 rust-getrandom
> > - lfsmake2 rust-getrandom-0.2.4
> > - lfsmake2 rust-typenum
> > lfsmake2 rust-version-check
> > - lfsmake2 rust-generic-array
> > - lfsmake2 rust-crypto-common
> > - lfsmake2 rust-cipher
> > - lfsmake2 rust-hex
> > lfsmake2 rust-syn-1.0.109
> > - lfsmake2 rust-syn-2.0.90
> > - lfsmake2 rust-home
> > lfsmake2 rust-lazy-static
> > lfsmake2 rust-aho-corasick
> > lfsmake2 rust-regex-syntax
> > lfsmake2 rust-regex
> > - lfsmake2 rust-same-file
> > - lfsmake2 rust-walkdir
> > - lfsmake2 rust-dirs
> > - lfsmake2 rust-toolchain_find
> > - lfsmake2 rust-synstructure
> > - lfsmake2 rust-block-buffer
> > - lfsmake2 rust-digest
> > - lfsmake2 rust-ppv-lite86
> > - lfsmake2 rust-rand_core
> > - lfsmake2 rust-rand_core-0.4.2
> > - lfsmake2 rust-rand_core-0.3.1
> > - lfsmake2 rust-rand_chacha
> > - lfsmake2 rust-rand_hc
> > - lfsmake2 rust-rand
> > - lfsmake2 rust-rdrand
> > - lfsmake2 rust-rand-0.4
> > - lfsmake2 rust-log-0.4.14
> > - lfsmake2 rust-num_cpus
> > - lfsmake2 rust-crossbeam-utils
> > lfsmake2 rust-autocfg
> > - lfsmake2 rust-memoffset
> > lfsmake2 rust-scopeguard
> > - lfsmake2 rust-crossbeam-epoch
> > - lfsmake2 rust-crossbeam-deque
> > - lfsmake2 rust-either
> > - lfsmake2 rust-crossbeam-channel
> > - lfsmake2 rust-rayon-core
> > - lfsmake2 rust-rayon
> > - lfsmake2 rust-remove_dir_all
> > - lfsmake2 rust-tempdir
> > - lfsmake2 rust-glob
> > lfsmake2 rust-once_cell
> > - lfsmake2 rust-once_cell-1.9.0
> > - lfsmake2 rust-termcolor
> > lfsmake2 rust-serde_spanned
> > lfsmake2 rust-toml_datetime
> > lfsmake2 rust-winnow
> > lfsmake2 rust-toml_edit
> > lfsmake2 rust-toml
> > - lfsmake2 rust-target-triple
> > - lfsmake2 rust-trybuild
> > lfsmake2 rust-unindent
> > lfsmake2 rust-proc-macro-hack
> > - lfsmake2 rust-indoc-impl
> > lfsmake2 rust-indoc-impl-0.3.6
> > - lfsmake2 rust-indoc
> > lfsmake2 rust-indoc-0.3.6
> > lfsmake2 rust-instant
> > lfsmake2 rust-lock_api
> > lfsmake2 rust-parking_lot_core
> > lfsmake2 rust-parking_lot
> > lfsmake2 rust-paste-impl
> > - lfsmake2 rust-paste
> > lfsmake2 rust-paste-0.1.18
> > - lfsmake2 rust-ctor
> > - lfsmake2 rust-ghost
> > - lfsmake2 rust-inventory-impl
> > - lfsmake2 rust-inventory
> > lfsmake2 rust-pyo3-build-config
> > lfsmake2 rust-pyo3-macros-backend
> > lfsmake2 rust-pyo3-macros
> > lfsmake2 rust-pyo3
> > lfsmake2 rust-num-traits
> > lfsmake2 rust-num-integer
> > - lfsmake2 rust-num_threads
> > lfsmake2 rust-time
> > lfsmake2 rust-iana-time-zone
> > lfsmake2 rust-chrono
> > @@ -1775,7 +1714,6 @@ build_system() {
> > lfsmake2 rust-Inflector
> > lfsmake2 rust-ouroboros_macro
> > lfsmake2 rust-aliasable
> > - lfsmake2 rust-stable_deref_trait
> > lfsmake2 rust-ouroboros
> > lfsmake2 rust-base64
> > lfsmake2 rust-pem
> > -- 
> > 2.47.3
> > 
> > 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-28 18:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-28 18:02 [PATCH] rust: Cleanup/Drop unneeded modules Stefan Schantl
2026-01-28 18:05 ` Michael Tremer
2026-01-28 18:38   ` Stefan Schantl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox