From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim FitzGeorge <ipfr@tfitzgeorge.me.uk>
To: development@lists.ipfire.org
Subject: Re: [PATCH] BUG12070: Its not possible to use the underscore in email
 addresses
Date: Thu, 20 Jun 2019 23:13:22 +0100
Message-ID: <5deb274b-c10b-b085-2f3f-b77f8015fef8@tfitzgeorge.me.uk>
In-Reply-To: <20190618075535.18313-1-alexander.marx@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1663599437224133843=="
List-Id: <development.lists.ipfire.org>

--===============1663599437224133843==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On checking with RFC 3696, I think there are many more characters that
are legal in an email address local part.=C2=A0 This includes '@' (although
it has to be quoted), which would completely break validemail if used.=C2=A0
It's apparently difficult to fully validate the local part of an email
address.

On 18/06/2019 08:55, Alexander Marx wrote:
> Using IPFire's Mailservice does not allow to enter a senders mail address w=
ith the underscore.
> The function used to verify that is used from general-functions.pl.
> Now the function 'validemail' allows the underscore in the address.
>
> Fixes: #12070
> ---
>  config/cfgroot/general-functions.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/cfgroot/general-functions.pl b/config/cfgroot/general-f=
unctions.pl
> index 04e36969c..aefcfb687 100644
> --- a/config/cfgroot/general-functions.pl
> +++ b/config/cfgroot/general-functions.pl
> @@ -784,7 +784,7 @@ sub validemail {
>      return 0 if ( substr($parts[1],-1,1) eq '.' );
> =20
>      #check first addresspart (before '@' sign)
> -    return 0 if  ( $parts[0] !~ m/^[a-zA-Z0-9\.!\-\+#]+$/ );
> +    return 0 if  ( $parts[0] !~ m/^[a-zA-Z0-9\.!\-\_\+#]+$/ );
> =20
>      #check second addresspart (after '@' sign)
>      return 0 if  ( $parts[1] !~ m/^[a-zA-Z0-9\.\-]+$/ );



--===============1663599437224133843==--