From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] getrrdimage.cgi: Allow more non-word characters in the URL
Date: Thu, 13 May 2021 14:26:10 +0200 [thread overview]
Message-ID: <5ee417ec-81da-1afd-9358-84ec04f779bf@ipfire.org> (raw)
In-Reply-To: <20210513092705.1043-1-hofmann@leo-andres.de>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>
On 13/05/2021 11:27, Leo-Andres Hofmann wrote:
> As discussed in bug #12615
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/cgi-bin/getrrdimage.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
> index 34ee4bf7a..c08247c57 100644
> --- a/html/cgi-bin/getrrdimage.cgi
> +++ b/html/cgi-bin/getrrdimage.cgi
> @@ -50,7 +50,7 @@ my $graph = $query{'graph'};
> my $range = lc $query{'range'}; # lower case
>
> # Check parameters
> -unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w-]+?$/) && ($range ~~ @Graphs::time_ranges)) {
> +unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) {
> # Send HTTP headers
> _start_png_output();
>
next prev parent reply other threads:[~2021-05-13 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 9:27 Leo-Andres Hofmann
2021-05-13 12:26 ` Adolf Belka [this message]
2021-05-14 7:14 ` Peter Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ee417ec-81da-1afd-9358-84ec04f779bf@ipfire.org \
--to=adolf.belka@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox