From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Testing required for modified dhcp.cgi file related to bug 10743 Date: Sat, 14 Nov 2020 17:40:48 +0100 Message-ID: <5ef16d52-5bb8-cdfd-52f6-9bc6d5c369c3@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3106873986233213140==" List-Id: --===============3106873986233213140== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Matthias, Thanks very much for the feedback. When I ran it with my test bed setup I had= some address pools but in my production setup I only have fixed leases in Gr= een. So your testing result is exactly what I needed to find. I need to think how to modify the changes in dhcp.cgi to allow for no address= pools. I will come back if I am able to find a solution. I will also test now with n= o address pools in future. Regards, Adolf On 14/11/2020 17:26, Matthias Fischer wrote: > Hi, >=20 > Tested - sorry, didn't work - 'dhcp' wouldn't start. Perhaps my fault. I > have suspected something like this for my machine. >=20 > /var/log/messages tells me: >=20 > ... > Nov 14 16:36:27 ipfire dhcpd: /etc/dhcp/dhcpd.conf line 16: Pool > declaration with no address range. > Nov 14 16:36:27 ipfire dhcpd: } > Nov 14 16:36:27 ipfire dhcpd: ^ > Nov 14 16:36:27 ipfire dhcpd: Pool declarations must always contain at least > Nov 14 16:36:27 ipfire dhcpd: one range statement. > Nov 14 16:36:27 ipfire dhcpd: /etc/dhcp/dhcpd.conf line 30: Pool > declaration with no address range. > Nov 14 16:36:27 ipfire dhcpd: } > Nov 14 16:36:27 ipfire dhcpd: ^ > Nov 14 16:36:27 ipfire dhcpd: Pool declarations must always contain at least > Nov 14 16:36:27 ipfire dhcpd: one range statement. > Nov 14 16:36:27 ipfire dhcpd: Configuration file errors encountered -- > exiting > ... >=20 > And...yes... [Hrm!]...I'm running 'dhcpd' on GREEN and BLUE with NO > address pools. Only fixed leases. >=20 > Anything I can do to test this without address ranges? >=20 > Best, > Matthias >=20 > On 14.11.2020 13:29, Adolf Belka wrote: >> Hi all, >> >> I created a modified dhcp.cgi file for bug 10743. This gives the opportuni= ty to add deny unknown-clients or deny known-clients to the dhcpd.conf file f= or the green and blue subnets. >> >> Unfortunately one of the bug originators has decided to move away from IPF= ire and will not carry out any testing of this modification to confirm it wor= ks before I create a patch and submit it. >> >> The modification provides a radio button set to green and blue that offers= :- >> >> allow all clients >> deny unknown-clients >> deny known-clients >> >> The allow all clients option gives the same setup as currently and is the = default setting for the radio button set. >> >> The modified dhcp.cgi file is attached. I would appreciate it if you could= test this out and let me know if there are any unexpected outcomes. >> >> Regards, >> >> Adolf. >> >=20 --===============3106873986233213140==--