From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vnstat 2.6: Fix for lfs
Date: Sat, 11 Apr 2020 19:03:55 +0100
Message-ID: <6093E18A-FBD1-4A96-93E8-F98784BBBD9D@ipfire.org>
In-Reply-To: <b398086a-a86b-0cf2-d1c6-894b1abf5f36@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5776117921228783731=="
List-Id: <development.lists.ipfire.org>

--===============5776117921228783731==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 11 Apr 2020, at 17:39, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Hi.
>=20
> On 11.04.2020 17:28, Michael Tremer wrote:
>> Hello,
>>=20
>> Thanks for the patch, but this only solves one of my concerns.
>=20
> You mean the exit status for the 'stop'-section?

No, everywhere.

>=20
>> What about printing the colourful exit status more than once?
>=20
> Done... ;-)
>=20
>> Best,
>> -Michael
>>=20
>>> On 11 Apr 2020, at 15:38, Matthias Fischer <matthias.fischer(a)ipfire.org=
> wrote:
>>>=20
>>> Removed 'sleep 2'
>>>=20
>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>> ---
>>> src/initscripts/system/vnstat | 2 --
>>> 1 file changed, 2 deletions(-)
>>>=20
>>> diff --git a/src/initscripts/system/vnstat b/src/initscripts/system/vnstat
>>> index bcc19c3ab..a21905d75 100755
>>> --- a/src/initscripts/system/vnstat
>>> +++ b/src/initscripts/system/vnstat
>>> @@ -20,14 +20,12 @@ case "$1" in
>>>=20
>>> 		boot_mesg "Starting vnstatd..."
>>> 		loadproc /usr/sbin/vnstatd -d --alwaysadd
>>> -		sleep 2
>>> 		evaluate_retval
>>> 		;;
>>>=20
>>> 	stop)
>>> 		boot_mesg "Stopping vnstatd..."
>>> 		killproc /usr/sbin/vnstatd
>>> -		sleep 2
>>> 		evaluate_retval
>>>=20
>>> 		umount_ramdisk "${VNSTATLOG}"
>>> --=20
>>> 2.18.0
>>>=20
>>=20
>=20


--===============5776117921228783731==--