public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] rules.pl: Proposed patch - Fix for missing bracket
Date: Sun, 12 Mar 2023 18:19:19 +0100	[thread overview]
Message-ID: <609df3b3-c4b5-593a-e91e-7b61224db547@ipfire.org> (raw)
In-Reply-To: <20230312132800.1625540-1-matthias.fischer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

Good find. ;)

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 12.03.2023 um 14:28 schrieb Matthias Fischer:
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>   config/firewall/rules.pl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
> index 80985ca53..6c08feb86 100644
> --- a/config/firewall/rules.pl
> +++ b/config/firewall/rules.pl
> @@ -761,7 +761,7 @@ sub ipblocklist () {
>   			}
>   
>   			# Check if logging is enabled.
> -			if($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq "on")) {
> +			if(($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq "on")) {
>   				# Create logging rule.
>   				run("$IPTABLES -A ${blocklist}_DROP -j LOG -m limit --limit 10/second --log-prefix \"BLKLST_$blocklist \"");
>   			}

      reply	other threads:[~2023-03-12 17:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-12 13:28 Matthias Fischer
2023-03-12 17:19 ` Bernhard Bitsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=609df3b3-c4b5-593a-e91e-7b61224db547@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox