From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] rules.pl: Proposed patch - Fix for missing bracket
Date: Sun, 12 Mar 2023 18:19:19 +0100
Message-ID: <609df3b3-c4b5-593a-e91e-7b61224db547@ipfire.org>
In-Reply-To: <20230312132800.1625540-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0691694064040661506=="
List-Id: <development.lists.ipfire.org>

--===============0691694064040661506==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Good find. ;)

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 12.03.2023 um 14:28 schrieb Matthias Fischer:
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>   config/firewall/rules.pl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
> index 80985ca53..6c08feb86 100644
> --- a/config/firewall/rules.pl
> +++ b/config/firewall/rules.pl
> @@ -761,7 +761,7 @@ sub ipblocklist () {
>   			}
>  =20
>   			# Check if logging is enabled.
> -			if($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq =
"on")) {
> +			if(($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq=
 "on")) {
>   				# Create logging rule.
>   				run("$IPTABLES -A ${blocklist}_DROP -j LOG -m limit --limit 10/second=
 --log-prefix \"BLKLST_$blocklist \"");
>   			}

--===============0691694064040661506==--