Hello Daniel,

This patch looks good to me.

I had assumed that we automatically enabled STP on all bridges, but apparently we do not.

How do we process with this?

I suppose it is not the most user-friendly way to ask the user to edit the configuration file. This either must be documented somewhere or the zoneconfig.cgi script needs to be extended to allow enabling STP.

Does anyone want to be able to change any STP parameters like priority or cost of the ports?

Best,
-Michael

> On 19 Nov 2020, at 13:18, Daniel Weismüller <daniel.weismueller(a)ipfire.org> wrote:
> 
> Signed-off-by: Daniel Weismüller <daniel.weismueller(a)ipfire.org>
> ---
> config/udev/network-hotplug-bridges | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/config/udev/network-hotplug-bridges b/config/udev/network-hotplug-bridges
> index 33d6d65ba..7431377bb 100644
> --- a/config/udev/network-hotplug-bridges
> +++ b/config/udev/network-hotplug-bridges
> @@ -81,6 +81,7 @@ MODE="$(get_value "${ZONE}_MODE")"
> 
> # The name of the virtual bridge
> BRIDGE="$(get_value "${ZONE}_DEV")"
> +STP="$(get_value "${ZONE}_STP")"
> 
> case "${MODE}" in
> 	bridge)
> @@ -89,7 +90,8 @@ case "${MODE}" in
> 
> 		# We need to create the bridge if it doesn't exist, yet
> 		if [ ! -d "/sys/class/net/${BRIDGE}" ]; then
> -			ip link add "${BRIDGE}" address "${ADDRESS}" type bridge
> +			ip link add "${BRIDGE}" address "${ADDRESS}" type bridge \
> +				$([ "${STP}" = "on" ] && echo "stp_state 1")
> 			#ip link set "${BRIDGE}" up
> 		fi
> 
> -- 
> 2.28.0
>