From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Add button spacing on 'Firewall/Firewall Groups' page.
Date: Wed, 05 Mar 2025 11:56:41 +0000 [thread overview]
Message-ID: <62B0F62C-BACD-470E-8D7E-71608FA80401@ipfire.org> (raw)
In-Reply-To: <20250227204357.249689-2-stephen@firemypi.org>
[-- Attachment #1: Type: text/plain, Size: 2407 bytes --]
Hello Stephen,
Thank you for the patch. I am seeing three emails here which all seem to be almost identical?
Was there a problem submitting the patch or are there actually any changes here which I have missed?
-Michael
> On 27 Feb 2025, at 20:43, Stephen Cuka <stephen(a)firemypi.org> wrote:
>
> Add spacing between showmenu() buttons on Firewall/Firewall Groups page to improve the look of the page.
>
> No changes to the functions of the page.
>
> Signed-off-by: Stephen Cuka <stephen(a)firemypi.org>
> ---
> html/cgi-bin/fwhosts.cgi | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
> index d6be6c40e..d29940b8d 100644
> --- a/html/cgi-bin/fwhosts.cgi
> +++ b/html/cgi-bin/fwhosts.cgi
> @@ -1320,10 +1320,29 @@ sub showmenu {
> &Header::openbox('100%', 'left',);
> print "$Lang::tr{'fwhost welcome'}";
> print<<END;
> - <br><br><table border='0' width='100%'>
> - <tr><td><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}' ></form></td>
> - <td align='right'><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}' ></form></td></tr>
> - <tr><td colspan='6'></td></tr></table>
> + <br><br>
> + <table border='0' width='100%'>
> + <tr>
> + <td>
> + <form method='post'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}'>
> + </form>
> + </td>
> + <td align='right'>
> + <form method='post'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}'>
> + </form>
> + </td>
> + </tr>
> + <tr>
> + <td colspan='6'>
> + </td>
> + </tr>
> + </table>
> END
> &Header::closebox();
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-03-05 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 9:26 Stephen Cuka
2025-03-05 11:56 ` Michael Tremer [this message]
[not found] ` <82aba8d9-5fa2-4ece-bec0-b1068ac10fc8@firemypi.org>
2025-03-06 10:40 ` Michael Tremer
2025-03-02 9:26 Stephen Cuka
2025-03-02 9:26 Stephen Cuka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62B0F62C-BACD-470E-8D7E-71608FA80401@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox