From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] dns.cgi: Fixes bug#12395 - German umlauts not correctly
 displayed in remarks
Date: Wed, 28 Feb 2024 16:11:39 +0000
Message-ID: <62B6E2EA-282A-48AA-8A23-DF745FB738FE@ipfire.org>
In-Reply-To: <20240228133526.6757-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0332530495725429624=="
List-Id: <development.lists.ipfire.org>

--===============0332530495725429624==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Thank you for this patch.

Indeed we only need to escape once.

-Michael

> On 28 Feb 2024, at 13:35, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> - If Freifunk M=C3=BCnchen e.V. is entered as a remark it gets converted to
>   Freifunk M=C3=83=C2=BCnchen e.V.
> - This is because cleanhtml is used on the remark text before saving it to =
the file  and
>   the HTML::Entities::encode_entities command that is run on that remark te=
xt encodes all
>   higher bit characters as unsafe characters and replaces them with their H=
TML entity
>   representation.
> - Have tested out the remark with a range of different characters with diac=
ritical marks
>   and all of the ones tested were re-written.
> - The use of the cleanhtml makes sense when used on URL's or on text that i=
s going to be
>   printed as part of the HTML code for a page but it doesn't seem to make s=
ense for text
>   used in a remark.
> - The cleanhtml function is only used on the remark text in dns.cgi and not=
 on any other
>   entries on the page.
> - Removing the call to the cleanhtml function results in the German umlauts=
 being printed
>   in the remark section.
> - Many of the WUI pages have the cleanhtml function used on remark or comme=
nt text.
> - fwhosts.cgi does not use cleanhtml anywhere. So all its remark sections w=
ork with
>   characters with diacritical marks.
> - If this patch is accepted, I will then submit patches for the other WUI p=
ages where
>   characters with diacritical marks are re-written in remark or comment sec=
tions.
>=20
> Fixes: Bug#12395
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> html/cgi-bin/dns.cgi | 2 --
> 1 file changed, 2 deletions(-)
>=20
> diff --git a/html/cgi-bin/dns.cgi b/html/cgi-bin/dns.cgi
> index 0a34d3fd6..f3dd5c7a9 100644
> --- a/html/cgi-bin/dns.cgi
> +++ b/html/cgi-bin/dns.cgi
> @@ -141,8 +141,6 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($c=
giparams{'SERVERS'} eq $L
>=20
> # Go further if there was no error.
> if ( ! $errormessage) {
> - # Check if a remark has been entered.
> - $cgiparams{'REMARK'} =3D &Header::cleanhtml($cgiparams{'REMARK'});
>=20
> my %dns_servers =3D ();
> my $id;
> --=20
> 2.44.0
>=20


--===============0332530495725429624==--