* [PATCH] backup definitions: housekeeping to remove orphaned definitions
@ 2021-10-23 11:54 Adolf Belka
2021-10-23 12:25 ` Peter Müller
2021-10-25 18:33 ` Michael Tremer
0 siblings, 2 replies; 3+ messages in thread
From: Adolf Belka @ 2021-10-23 11:54 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]
- check_mk_agent, client175 & lcr are addons that have been removed so the backup
definitions are no longer required.
- dma is not a package but a core program and has its config backup requirements
built into the core backup include file so the addon backup definition is not
used or needed.
- No issues found in the build after these files were removed.
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
config/backup/includes/check_mk_agent | 1 -
config/backup/includes/client175 | 2 --
config/backup/includes/dma | 5 -----
config/backup/includes/lcr | 6 ------
4 files changed, 14 deletions(-)
delete mode 100644 config/backup/includes/check_mk_agent
delete mode 100644 config/backup/includes/client175
delete mode 100644 config/backup/includes/dma
delete mode 100644 config/backup/includes/lcr
diff --git a/config/backup/includes/check_mk_agent b/config/backup/includes/check_mk_agent
deleted file mode 100644
index ca710461b..000000000
--- a/config/backup/includes/check_mk_agent
+++ /dev/null
@@ -1 +0,0 @@
-/etc/check_mk/
diff --git a/config/backup/includes/client175 b/config/backup/includes/client175
deleted file mode 100644
index 6cde8e8ca..000000000
--- a/config/backup/includes/client175
+++ /dev/null
@@ -1,2 +0,0 @@
-/src/client175/site.conf
-/var/ipfire/mpfire/*.m3u
diff --git a/config/backup/includes/dma b/config/backup/includes/dma
deleted file mode 100644
index 7c7520551..000000000
--- a/config/backup/includes/dma
+++ /dev/null
@@ -1,5 +0,0 @@
-/var/ipfire/dma
-/var/ipfire/dma/dma.conf
-/var/ipfire/dma/auth.conf
-/var/ipfire/dma/mail.conf
-/var/spool/dma
diff --git a/config/backup/includes/lcr b/config/backup/includes/lcr
deleted file mode 100644
index 618f4c784..000000000
--- a/config/backup/includes/lcr
+++ /dev/null
@@ -1,6 +0,0 @@
-/var/ipfire/lcr/extensions
-/var/ipfire/lcr/directory.list
-/var/ipfire/lcr/interface.conf
-/var/ipfire/lcr/options.conf
-/var/ipfire/lcr/routing.conf
-/var/log/lcr
--
2.33.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] backup definitions: housekeeping to remove orphaned definitions
2021-10-23 11:54 [PATCH] backup definitions: housekeeping to remove orphaned definitions Adolf Belka
@ 2021-10-23 12:25 ` Peter Müller
2021-10-25 18:33 ` Michael Tremer
1 sibling, 0 replies; 3+ messages in thread
From: Peter Müller @ 2021-10-23 12:25 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2220 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> - check_mk_agent, client175 & lcr are addons that have been removed so the backup
> definitions are no longer required.
> - dma is not a package but a core program and has its config backup requirements
> built into the core backup include file so the addon backup definition is not
> used or needed.
> - No issues found in the build after these files were removed.
>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/backup/includes/check_mk_agent | 1 -
> config/backup/includes/client175 | 2 --
> config/backup/includes/dma | 5 -----
> config/backup/includes/lcr | 6 ------
> 4 files changed, 14 deletions(-)
> delete mode 100644 config/backup/includes/check_mk_agent
> delete mode 100644 config/backup/includes/client175
> delete mode 100644 config/backup/includes/dma
> delete mode 100644 config/backup/includes/lcr
>
> diff --git a/config/backup/includes/check_mk_agent b/config/backup/includes/check_mk_agent
> deleted file mode 100644
> index ca710461b..000000000
> --- a/config/backup/includes/check_mk_agent
> +++ /dev/null
> @@ -1 +0,0 @@
> -/etc/check_mk/
> diff --git a/config/backup/includes/client175 b/config/backup/includes/client175
> deleted file mode 100644
> index 6cde8e8ca..000000000
> --- a/config/backup/includes/client175
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/src/client175/site.conf
> -/var/ipfire/mpfire/*.m3u
> diff --git a/config/backup/includes/dma b/config/backup/includes/dma
> deleted file mode 100644
> index 7c7520551..000000000
> --- a/config/backup/includes/dma
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/var/ipfire/dma
> -/var/ipfire/dma/dma.conf
> -/var/ipfire/dma/auth.conf
> -/var/ipfire/dma/mail.conf
> -/var/spool/dma
> diff --git a/config/backup/includes/lcr b/config/backup/includes/lcr
> deleted file mode 100644
> index 618f4c784..000000000
> --- a/config/backup/includes/lcr
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -/var/ipfire/lcr/extensions
> -/var/ipfire/lcr/directory.list
> -/var/ipfire/lcr/interface.conf
> -/var/ipfire/lcr/options.conf
> -/var/ipfire/lcr/routing.conf
> -/var/log/lcr
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] backup definitions: housekeeping to remove orphaned definitions
2021-10-23 11:54 [PATCH] backup definitions: housekeeping to remove orphaned definitions Adolf Belka
2021-10-23 12:25 ` Peter Müller
@ 2021-10-25 18:33 ` Michael Tremer
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tremer @ 2021-10-25 18:33 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2308 bytes --]
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 23 Oct 2021, at 12:54, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>
> - check_mk_agent, client175 & lcr are addons that have been removed so the backup
> definitions are no longer required.
> - dma is not a package but a core program and has its config backup requirements
> built into the core backup include file so the addon backup definition is not
> used or needed.
> - No issues found in the build after these files were removed.
>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/backup/includes/check_mk_agent | 1 -
> config/backup/includes/client175 | 2 --
> config/backup/includes/dma | 5 -----
> config/backup/includes/lcr | 6 ------
> 4 files changed, 14 deletions(-)
> delete mode 100644 config/backup/includes/check_mk_agent
> delete mode 100644 config/backup/includes/client175
> delete mode 100644 config/backup/includes/dma
> delete mode 100644 config/backup/includes/lcr
>
> diff --git a/config/backup/includes/check_mk_agent b/config/backup/includes/check_mk_agent
> deleted file mode 100644
> index ca710461b..000000000
> --- a/config/backup/includes/check_mk_agent
> +++ /dev/null
> @@ -1 +0,0 @@
> -/etc/check_mk/
> diff --git a/config/backup/includes/client175 b/config/backup/includes/client175
> deleted file mode 100644
> index 6cde8e8ca..000000000
> --- a/config/backup/includes/client175
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/src/client175/site.conf
> -/var/ipfire/mpfire/*.m3u
> diff --git a/config/backup/includes/dma b/config/backup/includes/dma
> deleted file mode 100644
> index 7c7520551..000000000
> --- a/config/backup/includes/dma
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/var/ipfire/dma
> -/var/ipfire/dma/dma.conf
> -/var/ipfire/dma/auth.conf
> -/var/ipfire/dma/mail.conf
> -/var/spool/dma
> diff --git a/config/backup/includes/lcr b/config/backup/includes/lcr
> deleted file mode 100644
> index 618f4c784..000000000
> --- a/config/backup/includes/lcr
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -/var/ipfire/lcr/extensions
> -/var/ipfire/lcr/directory.list
> -/var/ipfire/lcr/interface.conf
> -/var/ipfire/lcr/options.conf
> -/var/ipfire/lcr/routing.conf
> -/var/log/lcr
> --
> 2.33.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-23 11:54 [PATCH] backup definitions: housekeeping to remove orphaned definitions Adolf Belka
2021-10-23 12:25 ` Peter Müller
2021-10-25 18:33 ` Michael Tremer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox