From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <ahb.ipfire@gmail.com>
To: development@lists.ipfire.org
Subject: Re: [PATCH] strongswan: Update to 5.9.0
Date: Wed, 02 Sep 2020 23:35:58 +0200
Message-ID: <64870019-384e-2436-66d5-21b22a63bcc3@gmail.com>
In-Reply-To: <de1115c7-1291-4be6-5a56-3a675813db5c@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8206174607966027875=="
List-Id: <development.lists.ipfire.org>

--===============8206174607966027875==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hallo Michael,

I have rerun the builds of strongswan and postfix and run a diff on the previ=
ous rootfiles and the ones generated from the builds in the log directory. In=
 both cases there were no differences so I can confirm no change in the rootf=
iles.

Regards,

Adolf.


On 02/09/2020 15:52, Adolf Belka wrote:
> Hi Michael,
>
> Sorry for the error with the email address. Yes that was finger trouble. Th=
e first @ should have been a .
>
> Unfortunately I then copy/pasted that into the postfix patch, so that has t=
he same error.
>
> Didn't know about the "git commit -s" option. Will remember that for the fu=
ture.
>
>
> Regarding the rootfiles, I must admit I didn't look at them, for strongswan=
 or postfix, because the build didn't highlight that there was a difference t=
hat needed to be resolved. I had assumed that if the build didn't highlight a=
nything then the rootfiles were the same.
>
> For future builds I will explicitly check if there is any difference in the=
 rootfiles.
>
> I will also go back and check for strongswan and postfix and report back if=
 there is any difference requiring me to redo the patches.
>
> Regards,
>
> Adolf
>
> On 02/09/2020 15:29, Michael Tremer wrote:
>> Hi,
>>
>>> On 2 Sep 2020, at 09:36, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>>
>>> - Update strongswan from version 5.8.4 to 5.9.0
>>> =C2=A0 see https://wiki.strongswan.org/versions/78
>>>
>>> Supporting request from Peter M=C3=BCller
>>> Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com
>> This is a slightly invalid email address.
>>
>> You can simply run =E2=80=9Cgit commit -s=E2=80=9D and it will automatical=
ly add that line for you, so that you don=E2=80=99t have to worry about it an=
y more.
>>
>> Apart from that, the patch looks good. Did you check for any rootfile chan=
ges?
>>
>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>
>> Best,
>> -Michael
>>
>>> ---
>>> lfs/strongswan | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/lfs/strongswan b/lfs/strongswan
>>> index 3be90db9a..d62a37c81 100644
>>> --- a/lfs/strongswan
>>> +++ b/lfs/strongswan
>>> @@ -24,7 +24,7 @@
>>>
>>> include Config
>>>
>>> -VER=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 5.8.4
>>> +VER=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 5.9.0
>>>
>>> THISAPP=C2=A0=C2=A0=C2=A0 =3D strongswan-$(VER)
>>> DL_FILE=C2=A0=C2=A0=C2=A0 =3D $(THISAPP).tar.bz2
>>> @@ -40,7 +40,7 @@ objects =3D $(DL_FILE)
>>>
>>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>>
>>> -$(DL_FILE)_MD5 =3D 0634e7f40591bd3f6770e583c3f27d29
>>> +$(DL_FILE)_MD5 =3D 705628cddd5b7683ef8a688acd9514d8
>>>
>>> install : $(TARGET)
>>>
>>> --=20
>>> 2.28.0
>>>

--===============8206174607966027875==--