From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCHv2 4/4] grub-btrfsd: Drop redundant used PIDFILE mechanism
Date: Thu, 28 Mar 2024 10:31:55 +0000
Message-ID: <649C4462-EA7C-4D77-9606-3E2A087D56ED@ipfire.org>
In-Reply-To: <20240327193920.14311-4-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5921228344309121201=="
List-Id: <development.lists.ipfire.org>

--===============5921228344309121201==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 27 Mar 2024, at 19:39, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> This case is already covered by the PID mechanism of the used functions
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> src/initscripts/system/grub-btrfsd | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/src/initscripts/system/grub-btrfsd b/src/initscripts/system/gr=
ub-btrfsd
> index 26760f9be..49073a807 100644
> --- a/src/initscripts/system/grub-btrfsd
> +++ b/src/initscripts/system/grub-btrfsd
> @@ -33,16 +33,14 @@ case "$1" in
> btrfs)
>=20
> boot_mesg "Starting GRUB/Btrfs Daemon..."
> - loadproc -b -p "$PIDFILE" /usr/bin/grub-btrfsd --syslog "$SNAPSHOTDIR"
> - echo "$!" > "$PIDFILE"
> + loadproc -b /usr/bin/grub-btrfsd --syslog "$SNAPSHOTDIR"
> ;;
> esac
> ;;
>=20
> stop)
> boot_mesg "Stopping grub-btrfsd..."
> - killproc -p "$PIDFILE" /usr/bin/grub-btrfsd
> - sleep 1;
> + killproc /usr/bin/grub-btrfsd
> ;;
>=20
> restart)
> --=20
> 2.39.2
>=20


--===============5921228344309121201==--