public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: web UI: Add graph for connection tracking
Date: Mon, 24 Aug 2020 15:02:41 +0100	[thread overview]
Message-ID: <66E2227B-5C04-4F92-89B7-C55728AAA45D@ipfire.org> (raw)
In-Reply-To: <c706bee6-7ae5-96cb-7a3d-2e0e08cbdc0a@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]

Hello,

> On 23 Aug 2020, at 16:36, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Hi,
> 
> I couldn't help but notice this commit - not merged yet, but
> interesting: ;-)
> 
> https://git.ipfire.org/?p=people/ms/ipfire-2.x.git;a=commit;h=4bf0d000ffe961cdc5d9dbd27b3a11f900b3daed

Yes. I emailed it to the list, too.

You can directly reply to those patches :)

> I tested and found something.
> 
> 1. In 'netother.cgi' I changed:
> ...
> &Header::openbox('100%', 'center', $Lang::tr{'connnection tracking'});
> ...
> 
> To:
> ...
> &Header::openbox('100%', 'center', $Lang::tr{'connnections'});
> ...

I found “Connections” a little bit imprecise and preferred “Connection Tracking”, because that is more of less what we are doing here.

> Reason:
> In german language (e.g.), 'connection tracking' is translated to
> 'iptables-Verbindungsverfolgung'.

Yes, I would propose we drop the “iptables” bit from this string. For all languages.

> This string is too long for the box, so there is no headline, nothing.
> 
> I shorted this to 'connections', which is translated to 'Verbindungen' -
> and now the box has a headline. It took some time to figure this out.
> 
> 2. In 'graphs.pl' I changed:
> ...
> "-t $Lang::tr{'connection tracking'}",
> ...
> 
> To:
> ...
> "-t ".$Lang::tr{'connection tracking'}." ".$Lang::tr{'graph per'}."
> ".$Lang::tr{$period."-graph"},
> ...

That is probably helpful and in sync with the other graphs.

I got inspired by the entropy graph and that will probably have the same problem.

> 3. This triggered some commits, because in this context I found that the
> graph links for 'disk access', 'hardware', and 'entropy' differed.
> E.g.:
> https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=9a3fba8661b76bc455e553cf9d39550d5ea919b2

Great. See above.

> As a side effect, it seems that the cpu frequency went up => see attachment.

Interesting. That should obviously not happen when you only change the description. Are there any processes suddenly using a lot of CPU?

> Besides, graphs are looking good => see attachment.

Yay!

> 
> Jm2c!
> 
> Best,
> Matthias
> <connection_tracking - day.png><cpu_frequency - week.png>


           reply	other threads:[~2020-08-24 14:02 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <c706bee6-7ae5-96cb-7a3d-2e0e08cbdc0a@ipfire.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66E2227B-5C04-4F92-89B7-C55728AAA45D@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox