Hello,

> On 23 Aug 2020, at 16:36, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Hi,
> 
> I couldn't help but notice this commit - not merged yet, but
> interesting: ;-)
> 
> https://git.ipfire.org/?p=people/ms/ipfire-2.x.git;a=commit;h=4bf0d000ffe961cdc5d9dbd27b3a11f900b3daed

Yes. I emailed it to the list, too.

You can directly reply to those patches :)

> I tested and found something.
> 
> 1. In 'netother.cgi' I changed:
> ...
> &Header::openbox('100%', 'center', $Lang::tr{'connnection tracking'});
> ...
> 
> To:
> ...
> &Header::openbox('100%', 'center', $Lang::tr{'connnections'});
> ...

I found “Connections” a little bit imprecise and preferred “Connection Tracking”, because that is more of less what we are doing here.

> Reason:
> In german language (e.g.), 'connection tracking' is translated to
> 'iptables-Verbindungsverfolgung'.

Yes, I would propose we drop the “iptables” bit from this string. For all languages.

> This string is too long for the box, so there is no headline, nothing.
> 
> I shorted this to 'connections', which is translated to 'Verbindungen' -
> and now the box has a headline. It took some time to figure this out.
> 
> 2. In 'graphs.pl' I changed:
> ...
> "-t $Lang::tr{'connection tracking'}",
> ...
> 
> To:
> ...
> "-t ".$Lang::tr{'connection tracking'}." ".$Lang::tr{'graph per'}."
> ".$Lang::tr{$period."-graph"},
> ...

That is probably helpful and in sync with the other graphs.

I got inspired by the entropy graph and that will probably have the same problem.

> 3. This triggered some commits, because in this context I found that the
> graph links for 'disk access', 'hardware', and 'entropy' differed.
> E.g.:
> https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=9a3fba8661b76bc455e553cf9d39550d5ea919b2

Great. See above.

> As a side effect, it seems that the cpu frequency went up => see attachment.

Interesting. That should obviously not happen when you only change the description. Are there any processes suddenly using a lot of CPU?

> Besides, graphs are looking good => see attachment.

Yay!

> 
> Jm2c!
> 
> Best,
> Matthias
> <connection_tracking - day.png><cpu_frequency - week.png>