From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: web UI: Add graph for connection tracking
Date: Mon, 24 Aug 2020 15:02:41 +0100
Message-ID: <66E2227B-5C04-4F92-89B7-C55728AAA45D@ipfire.org>
In-Reply-To: <c706bee6-7ae5-96cb-7a3d-2e0e08cbdc0a@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4198197785045687452=="
List-Id: <development.lists.ipfire.org>

--===============4198197785045687452==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 23 Aug 2020, at 16:36, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Hi,
>=20
> I couldn't help but notice this commit - not merged yet, but
> interesting: ;-)
>=20
> https://git.ipfire.org/?p=3Dpeople/ms/ipfire-2.x.git;a=3Dcommit;h=3D4bf0d00=
0ffe961cdc5d9dbd27b3a11f900b3daed

Yes. I emailed it to the list, too.

You can directly reply to those patches :)

> I tested and found something.
>=20
> 1. In 'netother.cgi' I changed:
> ...
> &Header::openbox('100%', 'center', $Lang::tr{'connnection tracking'});
> ...
>=20
> To:
> ...
> &Header::openbox('100%', 'center', $Lang::tr{'connnections'});
> ...

I found =E2=80=9CConnections=E2=80=9D a little bit imprecise and preferred =
=E2=80=9CConnection Tracking=E2=80=9D, because that is more of less what we a=
re doing here.

> Reason:
> In german language (e.g.), 'connection tracking' is translated to
> 'iptables-Verbindungsverfolgung'.

Yes, I would propose we drop the =E2=80=9Ciptables=E2=80=9D bit from this str=
ing. For all languages.

> This string is too long for the box, so there is no headline, nothing.
>=20
> I shorted this to 'connections', which is translated to 'Verbindungen' -
> and now the box has a headline. It took some time to figure this out.
>=20
> 2. In 'graphs.pl' I changed:
> ...
> "-t $Lang::tr{'connection tracking'}",
> ...
>=20
> To:
> ...
> "-t ".$Lang::tr{'connection tracking'}." ".$Lang::tr{'graph per'}."
> ".$Lang::tr{$period."-graph"},
> ...

That is probably helpful and in sync with the other graphs.

I got inspired by the entropy graph and that will probably have the same prob=
lem.

> 3. This triggered some commits, because in this context I found that the
> graph links for 'disk access', 'hardware', and 'entropy' differed.
> E.g.:
> https://git.ipfire.org/?p=3Dpeople/mfischer/ipfire-2.x.git;a=3Dcommit;h=3D9=
a3fba8661b76bc455e553cf9d39550d5ea919b2

Great. See above.

> As a side effect, it seems that the cpu frequency went up =3D> see attachme=
nt.

Interesting. That should obviously not happen when you only change the descri=
ption. Are there any processes suddenly using a lot of CPU?

> Besides, graphs are looking good =3D> see attachment.

Yay!

>=20
> Jm2c!
>=20
> Best,
> Matthias
> <connection_tracking - day.png><cpu_frequency - week.png>


--===============4198197785045687452==--