From: Michael Tremer <michael.tremer@ipfire.org>
To: Stephen Cuka <stephen@firemypi.org>
Cc: development@lists.ipfire.org
Subject: Re: [PATCH] pakfire.cgi: Change titles on confirmation pages.
Date: Sun, 20 Apr 2025 12:21:05 +0100 [thread overview]
Message-ID: <66F81C65-29FD-4173-B320-3DADAF71F2F2@ipfire.org> (raw)
In-Reply-To: <20250418212833.62847-1-stephen@firemypi.org>
Thank you! Happy Easter!
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
> On 18 Apr 2025, at 22:28, Stephen Cuka <stephen@firemypi.org> wrote:
>
> - Change confirmation page titles from 'Request' to 'Install' and 'Remove'.
>
> Signed-off-by: Stephen Cuka <stephen@firemypi.org>
> ---
> doc/language_issues.de | 1 +
> doc/language_issues.en | 1 -
> doc/language_issues.es | 1 +
> doc/language_issues.fr | 1 +
> doc/language_issues.it | 1 +
> doc/language_issues.nl | 1 +
> doc/language_issues.pl | 1 +
> doc/language_issues.ru | 1 +
> doc/language_issues.tr | 1 +
> html/cgi-bin/pakfire.cgi | 6 +++---
> 10 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/doc/language_issues.de b/doc/language_issues.de
> index 9062d6a83..b5309f41b 100644
> --- a/doc/language_issues.de
> +++ b/doc/language_issues.de
> @@ -684,6 +684,7 @@ WARNING: translation string unused: removable device advice
> WARNING: translation string unused: repeat
> WARNING: translation string unused: reportfile
> WARNING: translation string unused: reportlevel
> +WARNING: translation string unused: request
> WARNING: translation string unused: requested data
> WARNING: translation string unused: reserved dst port
> WARNING: translation string unused: reserved src port
> diff --git a/doc/language_issues.en b/doc/language_issues.en
> index 9c7023b32..28eb622a6 100644
> --- a/doc/language_issues.en
> +++ b/doc/language_issues.en
> @@ -1572,7 +1572,6 @@ WARNING: untranslated string: remote subnet is invalid = Remote subnet is invali
> WARNING: untranslated string: remove = Remove
> WARNING: untranslated string: remove ca certificate = Remove CA certificate
> WARNING: untranslated string: remove x509 = Remove x509
> -WARNING: untranslated string: request = Request
> WARNING: untranslated string: required = Required
> WARNING: untranslated string: required field = Required field
> WARNING: untranslated string: reset = Reset
> diff --git a/doc/language_issues.es b/doc/language_issues.es
> index ca820ec36..00297e3ec 100644
> --- a/doc/language_issues.es
> +++ b/doc/language_issues.es
> @@ -741,6 +741,7 @@ WARNING: translation string unused: removable device advice
> WARNING: translation string unused: repeat
> WARNING: translation string unused: reportfile
> WARNING: translation string unused: reportlevel
> +WARNING: translation string unused: request
> WARNING: translation string unused: requested data
> WARNING: translation string unused: reserved dst port
> WARNING: translation string unused: reserved src port
> diff --git a/doc/language_issues.fr b/doc/language_issues.fr
> index a9193f89e..2ffa0a8dd 100644
> --- a/doc/language_issues.fr
> +++ b/doc/language_issues.fr
> @@ -716,6 +716,7 @@ WARNING: translation string unused: removable device advice
> WARNING: translation string unused: repeat
> WARNING: translation string unused: reportfile
> WARNING: translation string unused: reportlevel
> +WARNING: translation string unused: request
> WARNING: translation string unused: requested data
> WARNING: translation string unused: reserved dst port
> WARNING: translation string unused: reserved src port
> diff --git a/doc/language_issues.it b/doc/language_issues.it
> index 81aec2f6f..46f735637 100644
> --- a/doc/language_issues.it
> +++ b/doc/language_issues.it
> @@ -669,6 +669,7 @@ WARNING: translation string unused: removable device advice
> WARNING: translation string unused: repeat
> WARNING: translation string unused: reportfile
> WARNING: translation string unused: reportlevel
> +WARNING: translation string unused: request
> WARNING: translation string unused: requested data
> WARNING: translation string unused: reserved dst port
> WARNING: translation string unused: reserved src port
> diff --git a/doc/language_issues.nl b/doc/language_issues.nl
> index 83c1170a1..c1b076dcc 100644
> --- a/doc/language_issues.nl
> +++ b/doc/language_issues.nl
> @@ -668,6 +668,7 @@ WARNING: translation string unused: removable device advice
> WARNING: translation string unused: repeat
> WARNING: translation string unused: reportfile
> WARNING: translation string unused: reportlevel
> +WARNING: translation string unused: request
> WARNING: translation string unused: requested data
> WARNING: translation string unused: reserved dst port
> WARNING: translation string unused: reserved src port
> diff --git a/doc/language_issues.pl b/doc/language_issues.pl
> index aaeff1809..8bf0fa0db 100644
> --- a/doc/language_issues.pl
> +++ b/doc/language_issues.pl
> @@ -593,6 +593,7 @@ WARNING: translation string unused: removable device advice
> WARNING: translation string unused: repeat
> WARNING: translation string unused: reportfile
> WARNING: translation string unused: reportlevel
> +WARNING: translation string unused: request
> WARNING: translation string unused: requested data
> WARNING: translation string unused: reserved dst port
> WARNING: translation string unused: reserved src port
> diff --git a/doc/language_issues.ru b/doc/language_issues.ru
> index a6340e726..bce016c27 100644
> --- a/doc/language_issues.ru
> +++ b/doc/language_issues.ru
> @@ -588,6 +588,7 @@ WARNING: translation string unused: removable device advice
> WARNING: translation string unused: repeat
> WARNING: translation string unused: reportfile
> WARNING: translation string unused: reportlevel
> +WARNING: translation string unused: request
> WARNING: translation string unused: requested data
> WARNING: translation string unused: reserved dst port
> WARNING: translation string unused: reserved src port
> diff --git a/doc/language_issues.tr b/doc/language_issues.tr
> index f8a4f68a7..8dc81778d 100644
> --- a/doc/language_issues.tr
> +++ b/doc/language_issues.tr
> @@ -698,6 +698,7 @@ WARNING: translation string unused: removable device advice
> WARNING: translation string unused: repeat
> WARNING: translation string unused: reportfile
> WARNING: translation string unused: reportlevel
> +WARNING: translation string unused: request
> WARNING: translation string unused: requested data
> WARNING: translation string unused: reserved dst port
> WARNING: translation string unused: reserved src port
> diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi
> index 6a0c7a0a0..1246760df 100644
> --- a/html/cgi-bin/pakfire.cgi
> +++ b/html/cgi-bin/pakfire.cgi
> @@ -275,7 +275,7 @@ END
> # Show Pakfire install/remove dependencies and confirm form
> # (_is_pakfire_busy status was checked before and can be omitted)
> if (($cgiparams{'ACTION'} eq $Lang::tr{'pakfire install'}) && ($pagemode eq $PM_DEFAULT)) {
> - &Header::openbox("100%", "center", $Lang::tr{'request'});
> + &Header::openbox("100%", "center", $Lang::tr{'pakfire install'});
>
> my @pkgs = split(/\|/, $cgiparams{'INSPAKS'});
> my @output = &General::system_output("/usr/local/bin/pakfire", "resolvedeps", "--no-colors", @pkgs);
> @@ -318,7 +318,7 @@ END
> exit;
>
> } elsif (($cgiparams{'ACTION'} eq $Lang::tr{'remove'}) && ($pagemode eq $PM_DEFAULT)) {
> - &Header::openbox("100%", "center", $Lang::tr{'request'});
> + &Header::openbox("100%", "center", $Lang::tr{'remove'});
>
> my @pkgs = split(/\|/, $cgiparams{'DELPAKS'});
> my @output = &General::system_output("/usr/local/bin/pakfire", "resolvedeps", "--no-colors", @pkgs);
> @@ -416,7 +416,7 @@ if (($cgiparams{'ACTION'} eq $Lang::tr{'pakfire upgrade'}) && ($pagemode eq $PM_
> <input type='submit' name='ACTION' value='$Lang::tr{'pakfire upgrade'}'/>
> <input type='submit' name='ACTION' value='$Lang::tr{'cancel'}'/>
> </form>
> - </td>
> + </td>
> </tr>
> </table>
> END
> --
> 2.43.0
>
>
prev parent reply other threads:[~2025-04-20 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 21:28 Stephen Cuka
2025-04-20 11:21 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66F81C65-29FD-4173-B320-3DADAF71F2F2@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
--cc=stephen@firemypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox