From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4ZgQzp0zFmz332J for ; Sun, 20 Apr 2025 11:21:10 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4ZgQzk47F5z2xfT for ; Sun, 20 Apr 2025 11:21:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4ZgQzj4w48z7J; Sun, 20 Apr 2025 11:21:05 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1745148065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nnYF4cVKUPlU6ONPcPOdbko1rOyLZRUKDaFi30Qq2D8=; b=8aKkG1OifDL0v91dFA2LtCvICdiwRnqGxY8XBzfO9WDfWe5w/gKmmqqKPDgK6kLmWrL5Ji UjoZ8yWt7IoQT/Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1745148065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nnYF4cVKUPlU6ONPcPOdbko1rOyLZRUKDaFi30Qq2D8=; b=eF5v1KTSihNzuNrmyTwxqisrouMMyUfx5JDKCm1QxpJBRUHEJdjFkdtw3EMwGgcVgT4gil DF9AA7wwcmNr1rekMNJ10xEEKtMy7zVWp7YoWEKLiHiqs3n3W2+RwGlvDxy0KtWilrXANy 6Oa8Pbmc7R7kWbzXlKHa3P9CKUkI0+dkd892j+AvGCyacTXjsey0c2hAlzoWl+zalvdDPy vUqkTFezjMnCKCrQ7QLYkSNE12iS0aV+7V6PpXe8ucfSp0xu+J+nsoeVWlj2MeIET/2bkQ Ftn9jFYtyhaIyUqiRDBfKlK+af5PRp9hLb2kX7J65zBHXTkLhomXYvoS0WKrrQ== Content-Type: text/plain; charset=us-ascii Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH] pakfire.cgi: Change titles on confirmation pages. From: Michael Tremer In-Reply-To: <20250418212833.62847-1-stephen@firemypi.org> Date: Sun, 20 Apr 2025 12:21:05 +0100 Cc: development@lists.ipfire.org Content-Transfer-Encoding: quoted-printable Message-Id: <66F81C65-29FD-4173-B320-3DADAF71F2F2@ipfire.org> References: <20250418212833.62847-1-stephen@firemypi.org> To: Stephen Cuka Thank you! Happy Easter! Reviewed-by: Michael Tremer > On 18 Apr 2025, at 22:28, Stephen Cuka wrote: >=20 > - Change confirmation page titles from 'Request' to 'Install' and = 'Remove'. >=20 > Signed-off-by: Stephen Cuka > --- > doc/language_issues.de | 1 + > doc/language_issues.en | 1 - > doc/language_issues.es | 1 + > doc/language_issues.fr | 1 + > doc/language_issues.it | 1 + > doc/language_issues.nl | 1 + > doc/language_issues.pl | 1 + > doc/language_issues.ru | 1 + > doc/language_issues.tr | 1 + > html/cgi-bin/pakfire.cgi | 6 +++--- > 10 files changed, 11 insertions(+), 4 deletions(-) >=20 > diff --git a/doc/language_issues.de b/doc/language_issues.de > index 9062d6a83..b5309f41b 100644 > --- a/doc/language_issues.de > +++ b/doc/language_issues.de > @@ -684,6 +684,7 @@ WARNING: translation string unused: removable = device advice > WARNING: translation string unused: repeat > WARNING: translation string unused: reportfile > WARNING: translation string unused: reportlevel > +WARNING: translation string unused: request > WARNING: translation string unused: requested data > WARNING: translation string unused: reserved dst port > WARNING: translation string unused: reserved src port > diff --git a/doc/language_issues.en b/doc/language_issues.en > index 9c7023b32..28eb622a6 100644 > --- a/doc/language_issues.en > +++ b/doc/language_issues.en > @@ -1572,7 +1572,6 @@ WARNING: untranslated string: remote subnet is = invalid =3D Remote subnet is invali > WARNING: untranslated string: remove =3D Remove > WARNING: untranslated string: remove ca certificate =3D Remove CA = certificate > WARNING: untranslated string: remove x509 =3D Remove x509 > -WARNING: untranslated string: request =3D Request > WARNING: untranslated string: required =3D Required > WARNING: untranslated string: required field =3D Required field > WARNING: untranslated string: reset =3D Reset > diff --git a/doc/language_issues.es b/doc/language_issues.es > index ca820ec36..00297e3ec 100644 > --- a/doc/language_issues.es > +++ b/doc/language_issues.es > @@ -741,6 +741,7 @@ WARNING: translation string unused: removable = device advice > WARNING: translation string unused: repeat > WARNING: translation string unused: reportfile > WARNING: translation string unused: reportlevel > +WARNING: translation string unused: request > WARNING: translation string unused: requested data > WARNING: translation string unused: reserved dst port > WARNING: translation string unused: reserved src port > diff --git a/doc/language_issues.fr b/doc/language_issues.fr > index a9193f89e..2ffa0a8dd 100644 > --- a/doc/language_issues.fr > +++ b/doc/language_issues.fr > @@ -716,6 +716,7 @@ WARNING: translation string unused: removable = device advice > WARNING: translation string unused: repeat > WARNING: translation string unused: reportfile > WARNING: translation string unused: reportlevel > +WARNING: translation string unused: request > WARNING: translation string unused: requested data > WARNING: translation string unused: reserved dst port > WARNING: translation string unused: reserved src port > diff --git a/doc/language_issues.it b/doc/language_issues.it > index 81aec2f6f..46f735637 100644 > --- a/doc/language_issues.it > +++ b/doc/language_issues.it > @@ -669,6 +669,7 @@ WARNING: translation string unused: removable = device advice > WARNING: translation string unused: repeat > WARNING: translation string unused: reportfile > WARNING: translation string unused: reportlevel > +WARNING: translation string unused: request > WARNING: translation string unused: requested data > WARNING: translation string unused: reserved dst port > WARNING: translation string unused: reserved src port > diff --git a/doc/language_issues.nl b/doc/language_issues.nl > index 83c1170a1..c1b076dcc 100644 > --- a/doc/language_issues.nl > +++ b/doc/language_issues.nl > @@ -668,6 +668,7 @@ WARNING: translation string unused: removable = device advice > WARNING: translation string unused: repeat > WARNING: translation string unused: reportfile > WARNING: translation string unused: reportlevel > +WARNING: translation string unused: request > WARNING: translation string unused: requested data > WARNING: translation string unused: reserved dst port > WARNING: translation string unused: reserved src port > diff --git a/doc/language_issues.pl b/doc/language_issues.pl > index aaeff1809..8bf0fa0db 100644 > --- a/doc/language_issues.pl > +++ b/doc/language_issues.pl > @@ -593,6 +593,7 @@ WARNING: translation string unused: removable = device advice > WARNING: translation string unused: repeat > WARNING: translation string unused: reportfile > WARNING: translation string unused: reportlevel > +WARNING: translation string unused: request > WARNING: translation string unused: requested data > WARNING: translation string unused: reserved dst port > WARNING: translation string unused: reserved src port > diff --git a/doc/language_issues.ru b/doc/language_issues.ru > index a6340e726..bce016c27 100644 > --- a/doc/language_issues.ru > +++ b/doc/language_issues.ru > @@ -588,6 +588,7 @@ WARNING: translation string unused: removable = device advice > WARNING: translation string unused: repeat > WARNING: translation string unused: reportfile > WARNING: translation string unused: reportlevel > +WARNING: translation string unused: request > WARNING: translation string unused: requested data > WARNING: translation string unused: reserved dst port > WARNING: translation string unused: reserved src port > diff --git a/doc/language_issues.tr b/doc/language_issues.tr > index f8a4f68a7..8dc81778d 100644 > --- a/doc/language_issues.tr > +++ b/doc/language_issues.tr > @@ -698,6 +698,7 @@ WARNING: translation string unused: removable = device advice > WARNING: translation string unused: repeat > WARNING: translation string unused: reportfile > WARNING: translation string unused: reportlevel > +WARNING: translation string unused: request > WARNING: translation string unused: requested data > WARNING: translation string unused: reserved dst port > WARNING: translation string unused: reserved src port > diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi > index 6a0c7a0a0..1246760df 100644 > --- a/html/cgi-bin/pakfire.cgi > +++ b/html/cgi-bin/pakfire.cgi > @@ -275,7 +275,7 @@ END > # Show Pakfire install/remove dependencies and confirm form > # (_is_pakfire_busy status was checked before and can be omitted) > if (($cgiparams{'ACTION'} eq $Lang::tr{'pakfire install'}) && = ($pagemode eq $PM_DEFAULT)) { > - &Header::openbox("100%", "center", $Lang::tr{'request'}); > + &Header::openbox("100%", "center", $Lang::tr{'pakfire install'}); >=20 > my @pkgs =3D split(/\|/, $cgiparams{'INSPAKS'}); > my @output =3D &General::system_output("/usr/local/bin/pakfire", = "resolvedeps", "--no-colors", @pkgs); > @@ -318,7 +318,7 @@ END > exit; >=20 > } elsif (($cgiparams{'ACTION'} eq $Lang::tr{'remove'}) && ($pagemode = eq $PM_DEFAULT)) { > - &Header::openbox("100%", "center", $Lang::tr{'request'}); > + &Header::openbox("100%", "center", $Lang::tr{'remove'}); >=20 > my @pkgs =3D split(/\|/, $cgiparams{'DELPAKS'}); > my @output =3D &General::system_output("/usr/local/bin/pakfire", = "resolvedeps", "--no-colors", @pkgs); > @@ -416,7 +416,7 @@ if (($cgiparams{'ACTION'} eq $Lang::tr{'pakfire = upgrade'}) && ($pagemode eq $PM_ > > > > - > + > > > END > --=20 > 2.43.0 >=20 >=20