Re: [PATCH] core 130: Remove snort settings dir after convert has run.

[Stefan Schantl <stefan.schantl@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]

Hello Michael,
> Hi,
> 
> What happens when the converter has failed? Is that a possibility?

There is almost no risk, that this would be happened.

It contains checks if all corresponding files are present and will
contain the settings from them - I do not see a case where any problems
can be happen.

Best regards,

-Stefan

> 
> -Michael
> 
> > On 18 Mar 2019, at 18:46, Stefan Schantl <stefan.schantl(a)ipfire.org
> > > wrote:
> > 
> > When all settings have been converted, the files and directory are
> > not
> > needed anymore.
> > 
> > If they will be left and at a later time an backup will be
> > restored, the
> > converter will be started by the backup script again and would be
> > restore those
> > old snort settings and replace the current IPS settings.
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> > config/rootfiles/core/130/update.sh | 3 +++
> > 1 file changed, 3 insertions(+)
> > 
> > diff --git a/config/rootfiles/core/130/update.sh
> > b/config/rootfiles/core/130/update.sh
> > index d33321c32..f3dc0d85a 100644
> > --- a/config/rootfiles/core/130/update.sh
> > +++ b/config/rootfiles/core/130/update.sh
> > @@ -74,6 +74,9 @@ ldconfig
> > # Migrate snort configuration to suricata
> > /usr/sbin/convert-snort
> > 
> > +# Remove snort settings
> > +rm -rvf /var/ipfire/snort
> > +
> > # Start services
> > /etc/init.d/collectd restart
> > /etc/init.d/firewall restart
> > -- 
> > 2.20.1
> > 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]