From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schantl To: development@lists.ipfire.org Subject: Re: [PATCH] core 130: Remove snort settings dir after convert has run. Date: Mon, 18 Mar 2019 19:56:49 +0100 Message-ID: <66ff26261095dc31fe9db28fd674d7d2e0e9f568.camel@ipfire.org> In-Reply-To: <3839DBB5-5396-454D-BC86-A2391225899F@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1994725846427426856==" List-Id: --===============1994725846427426856== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hello Michael, > Hi, > > What happens when the converter has failed? Is that a possibility? There is almost no risk, that this would be happened. It contains checks if all corresponding files are present and will contain the settings from them - I do not see a case where any problems can be happen. Best regards, -Stefan > > -Michael > > > On 18 Mar 2019, at 18:46, Stefan Schantl > > wrote: > > > > When all settings have been converted, the files and directory are > > not > > needed anymore. > > > > If they will be left and at a later time an backup will be > > restored, the > > converter will be started by the backup script again and would be > > restore those > > old snort settings and replace the current IPS settings. > > > > Signed-off-by: Stefan Schantl > > --- > > config/rootfiles/core/130/update.sh | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/config/rootfiles/core/130/update.sh > > b/config/rootfiles/core/130/update.sh > > index d33321c32..f3dc0d85a 100644 > > --- a/config/rootfiles/core/130/update.sh > > +++ b/config/rootfiles/core/130/update.sh > > @@ -74,6 +74,9 @@ ldconfig > > # Migrate snort configuration to suricata > > /usr/sbin/convert-snort > > > > +# Remove snort settings > > +rm -rvf /var/ipfire/snort > > + > > # Start services > > /etc/init.d/collectd restart > > /etc/init.d/firewall restart > > -- > > 2.20.1 > > --===============1994725846427426856== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUVXTzBOWHRTcnZo YXN5dERuVHRkT0ZZK1RzdDRGQWx5UDZmRUFDZ2tRVHRkT0ZZK1QKc3Q3dWdoQUFyZGZ0bVlJdkVD dWNyUU5wMnNDVVlxV25RWVk3YURtUm1HNE5GK3FaT0l1NDVVOHloREtOSFc4Ugp4VWpxSHBtbitt VHVjcDcxNCtlRjgzMWdIdWpFWnJ0dmQyb0VtNUMvb2NiTVQvQVlGcHZRZ1Y2NW93eXVudFMwClhX dHRMN096dHlrVmpZOFlqODNSZXRxSEoyM09VUk9lQU83NU5PbUNSVm1ydzlhS1hJTkxobFRMOEIy SVJnd0gKanpHQldoV1NVdTlaQVFOa3FtKzZ2aDJRUExUNlZzdlo2QlJMNjhvTHZCL0d0enZ2ZW9j YTBkTVYvbTVQc1VWbQpBb0pNTEpBWnFka0I1djRvaisxYk1OM2sxcUJaZXlYZEhIVGpUWkc5UU03 WXpyK2l0Y2EzV3BxRWZLVTBVT29QCkZ1QjlSUlhFd3F2S1VHRENCdktqeW45M3NmYXQ3YkI1TFNp SCs5ZEk1NHJmdEZlSHNlNFhjQUdCbkc5ajFlK3AKRkdMd0t5S0FWZVZVSDZqWmxOZ3lKLy9UaHB2 QXBZVC9YYng4Z3R6NjlBTTJza0NsLzVvMS9ZTzkzNUExbjFaMQpEdm9SOUhXN3NDeDZWVE9JcHc1 WnUxNXltZE4zZy9xTm5vbmkwQmUxSjRSUnlCNCt5WGhsRWRkVkhwQjA1UjlpClIxWFVPdWtlcXUv MGZIS2NBY1h0UFRVL1VEaS9qczF0WFZUZ3VWeG9EckV1eGFVRW55bkFtRVZFVHZrbWk4VjUKVk9h dkNlY2pTWW5ObXg0U2J0SEhRTmU2OHVGVHlWNG0xMkhXdzR5YnJTa2JYem16Q2ViWS91Q3hrck5t L3J6ZQpPdEJCTHlnSUZhUEVuaE5SZEN0SWJOL3doUmNQVkc1YXNUeUkyaTgxVDByTklnRlZWZVU9 Cj0rNkZVCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============1994725846427426856==--