From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] cdrom: Rename ISO file
Date: Thu, 11 Aug 2022 18:27:57 +0000 [thread overview]
Message-ID: <68d5c1f2-70f6-c852-5684-35de228032d3@ipfire.org> (raw)
In-Reply-To: <20220811163817.1503583-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> This is cosmetic change to have the name of the ISO file similar to the
> flash image and also have all parts of it in a reasonable order.
>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> lfs/cdrom | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lfs/cdrom b/lfs/cdrom
> index ff4821fb5..a47faa49e 100644
> --- a/lfs/cdrom
> +++ b/lfs/cdrom
> @@ -123,6 +123,8 @@ GRUB_EFI_MODULES = \
> true \
> usb_keyboard
>
> +ISO_FILE = /install/images/$(SNAME)-$(VERSION)-core$(CORE)-$(BUILD_ARCH).iso
> +
> ###############################################################################
> # Top-level Rules
> ###############################################################################
> @@ -246,9 +248,8 @@ endif
> xargs md5sum > md5sum.txt
>
> mkdir -p /install/images
> - cd $(DIR_TMP)/cdrom && mkisofs $(ISO_ARGS) \
> - -o /install/images/$(SNAME)-$(VERSION).$(BUILD_ARCH)-full-core$(CORE).iso .
> + cd $(DIR_TMP)/cdrom && mkisofs $(ISO_ARGS) -o $(ISO_FILE) .
>
> ifeq "$(HAS_ISOLINUX)" "1"
> - isohybrid $(ISOHYBRID_ARGS) /install/images/$(SNAME)-$(VERSION).$(BUILD_ARCH)-full-core$(CORE).iso
> + isohybrid $(ISOHYBRID_ARGS) $(ISO_FILE)
> endif
prev parent reply other threads:[~2022-08-11 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 16:38 Michael Tremer
2022-08-11 18:27 ` Peter Müller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d5c1f2-70f6-c852-5684-35de228032d3@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox