From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/5] ids-functions.pl: Allow "5" download attempts for
 each provider before fail.
Date: Mon, 28 Mar 2022 16:16:59 +0100
Message-ID: <693D90BB-32FA-4093-94E7-46EC0F807F50@ipfire.org>
In-Reply-To: <a0ddca9d97110451cc20ad0635b7c73a3c67c8ce.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2573337461946085261=="
List-Id: <development.lists.ipfire.org>

--===============2573337461946085261==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

I generally don=E2=80=99t disagree with trying again. This should however hap=
pen after a little while (let=E2=80=99s say an hour or so).

Trying more than three times at one time is a bit excessive I would say. Let=
=E2=80=99s not try to DDoS other people=E2=80=99s systems :)

-Michael

> On 24 Mar 2022, at 18:23, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> Hello Michael,
>=20
> there was no special intention - I simple wanted to give the downloader
> more than just one chance to do it's job. For this I needed a value so
> I simple choosed "5".
>=20
> But I'm also fine with "3" or any other suggestion.
>=20
> Best regards,
>=20
> -Stefan
>=20
>> Hello,
>>=20
>> What is the rationale for five attempts? Why not three?
>>=20
>> -Michael
>>=20
>>> On 23 Mar 2022, at 04:04, Stefan Schantl
>>> <stefan.schantl(a)ipfire.org> wrote:
>>>=20
>>> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
>>> ---
>>> config/cfgroot/ids-functions.pl | 38 ++++++++++++++++++++++++------
>>> ---
>>> 1 file changed, 28 insertions(+), 10 deletions(-)
>>>=20
>>> diff --git a/config/cfgroot/ids-functions.pl b/config/cfgroot/ids-
>>> functions.pl
>>> index eb276030b..c8bc52b1b 100644
>>> --- a/config/cfgroot/ids-functions.pl
>>> +++ b/config/cfgroot/ids-functions.pl
>>> @@ -256,6 +256,10 @@ sub downloadruleset ($) {
>>>         # If no provider is given default to "all".
>>>         $provider //=3D 'all';
>>>=20
>>> +       # The amount of download attempts before giving up and
>>> +       # logging an error.
>>> +       my $max_dl_attempts =3D 5;
>>> +
>>>         # Hash to store the providers and access id's, for which
>>> rules should be downloaded.
>>>         my %sheduled_providers =3D ();
>>>=20
>>> @@ -364,19 +368,33 @@ sub downloadruleset ($) {
>>>                 # Pass the requested url to the downloader.
>>>                 my $request =3D HTTP::Request->new(GET =3D> $url);
>>>=20
>>> -               # Perform the request and save the output into the
>>> tmpfile.
>>> -               my $response =3D $downloader->request($request,
>>> $tmpfile);
>>> +               my $dl_attempt =3D 1;
>>> +               my $response;
>>>=20
>>> -               # Check if there was any error.
>>> -               unless ($response->is_success) {
>>> -                       # Obtain error.
>>> -                       my $error =3D $response->content;
>>> +               # Download and retry on failure.
>>> +               while ($dl_attempt <=3D $max_dl_attempts) {
>>> +                       # Perform the request and save the output
>>> into the tmpfile.
>>> +                       $response =3D $downloader->request($request,
>>> $tmpfile);
>>>=20
>>> -                       # Log error message.
>>> -                       &_log_to_syslog("Unable to download the
>>> ruleset. \($error\)");
>>> +                       # Check if the download was successfull.
>>> +                       if($response->is_success) {
>>> +                               # Break loop.
>>> +                               last;
>>>=20
>>> -                       # Return "1" - false.
>>> -                       return 1;
>>> +                       # Check if we ran out of download re-tries.
>>> +                       } elsif ($dl_attempt eq $max_dl_attempts) {
>>> +                               # Obtain error.
>>> +                               my $error =3D $response->content;
>>> +
>>> +                               # Log error message.
>>> +                               &_log_to_syslog("Unable to download
>>> the ruleset. \($error\)");
>>> +
>>> +                               # Return "1" - false.
>>> +                               return 1;
>>> +                       }
>>> +
>>> +                       # Increase download attempt counter.
>>> +                       $dl_attempt++;
>>>                 }
>>>=20
>>>                 # Obtain the connection headers.
>>> --=20
>>> 2.30.2
>>>=20
>>=20
>=20


--===============2573337461946085261==--