From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ddns: Add upstream patch to fix argparse list-token-providers command.
Date: Thu, 13 May 2021 09:47:48 +0100 [thread overview]
Message-ID: <69C172F7-DDD9-41AC-870B-19099B624E0C@ipfire.org> (raw)
In-Reply-To: <20210512180643.5920-1-stefan.schantl@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 2363 bytes --]
Hello,
> On 12 May 2021, at 19:06, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
>
> Fixes #12607.
>
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> lfs/ddns | 1 +
> ...13-fix-argparse-list-token-providers.patch | 23 +++++++++++++++++++
> 2 files changed, 24 insertions(+)
> create mode 100644 src/patches/ddns-013-fix-argparse-list-token-providers.patch
>
> diff --git a/lfs/ddns b/lfs/ddns
> index 98b374ed1..538cf7256 100644
> --- a/lfs/ddns
> +++ b/lfs/ddns
> @@ -77,6 +77,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-013-duckdns-new-api.patch
> cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-013-add-option-to-list-token-provider.patch
> cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-013-proper-encode-string.patch
> + cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-013-fix-argparse-list-token-providers.patch
>
> cd $(DIR_APP) && [ -x "configure" ] || sh ./autogen.sh
> cd $(DIR_APP) && ./configure \
> diff --git a/src/patches/ddns-013-fix-argparse-list-token-providers.patch b/src/patches/ddns-013-fix-argparse-list-token-providers.patch
> new file mode 100644
> index 000000000..065dbb666
> --- /dev/null
> +++ b/src/patches/ddns-013-fix-argparse-list-token-providers.patch
> @@ -0,0 +1,23 @@
> +commit 5e075681008174839a47cae698ae459c0ea3a30a
> +Author: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +Date: Wed May 12 19:59:01 2021 +0200
> +
> + Fix argsparse string for listing token providers.
> +
> + Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +
> +diff --git a/ddns.in b/ddns.in
> +index 538e4b0..20edd28 100755
> +--- a/ddns.in
> ++++ b/ddns.in
> +@@ -49,8 +49,8 @@ def main():
> + p_list_providers = subparsers.add_parser("list-providers",
> + help=_("List all available providers"))
> +
> +- # list-token-provider
> +- p_list_token_provider = subparsers.add_parser("list-token-provider",
> ++ # list-token-providers
> ++ p_list_token_provider = subparsers.add_parser("list-token-providers",
> + help=_("List all providers which supports authentication via token"))
There is another typo here. It is should be “support”.
> +
> + # update
> --
> 2.20.1
>
prev parent reply other threads:[~2021-05-13 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 18:06 Stefan Schantl
2021-05-13 8:47 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69C172F7-DDD9-41AC-870B-19099B624E0C@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox