public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] suricata: Do not load rules for dnp3 and modbus.
Date: Fri, 17 Dec 2021 11:17:15 +0100	[thread overview]
Message-ID: <6B07A840-92A0-4382-9D05-C983B261C1FE@ipfire.org> (raw)
In-Reply-To: <20211216192336.2595-1-stefan.schantl@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

This makes a lot of sense. Thank you.

> On 16 Dec 2021, at 20:23, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
> 
> The parsers for those are disabled in the suricata config so
> the rules are not needed, on the contrary they massively will spam
> warnings when launching suricate because of the disabled parsers.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> config/suricata/suricata-default-rules.yaml | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/config/suricata/suricata-default-rules.yaml b/config/suricata/suricata-default-rules.yaml
> index 64493e462..d6c358add 100644
> --- a/config/suricata/suricata-default-rules.yaml
> +++ b/config/suricata/suricata-default-rules.yaml
> @@ -5,13 +5,11 @@
>  - /usr/share/suricata/rules/app-layer-events.rules
>  - /usr/share/suricata/rules/decoder-events.rules
>  - /usr/share/suricata/rules/dhcp-events.rules
> - - /usr/share/suricata/rules/dnp3-events.rules
>  - /usr/share/suricata/rules/dns-events.rules
>  - /usr/share/suricata/rules/files.rules
>  - /usr/share/suricata/rules/http-events.rules
>  - /usr/share/suricata/rules/ipsec-events.rules
>  - /usr/share/suricata/rules/kerberos-events.rules
> - - /usr/share/suricata/rules/modbus-events.rules
>  - /usr/share/suricata/rules/nfs-events.rules
>  - /usr/share/suricata/rules/ntp-events.rules
>  - /usr/share/suricata/rules/smb-events.rules
> -- 
> 2.30.2
> 


      reply	other threads:[~2021-12-17 10:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 19:23 Stefan Schantl
2021-12-17 10:17 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6B07A840-92A0-4382-9D05-C983B261C1FE@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox