From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] RRD graphs: Remove padding around graph images
Date: Wed, 14 Jul 2021 17:31:10 +0100
Message-ID: <6B3B8C0D-4394-4875-98C0-B6E06565F5C5@ipfire.org>
In-Reply-To: <20210711182213.34-1-hofmann@leo-andres.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5918227174699871618=="
List-Id: <development.lists.ipfire.org>

--===============5918227174699871618==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

This looks like a valid fix:

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

Would it be a good consideration to render the graphs in SVG format instead? =
That way they could never be blurry because it is a vector graphic.

Best,
-Michael

> On 11 Jul 2021, at 19:22, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wrot=
e:
>=20
> The images inherited padding from the general design and
> have been resized to fit the layout, resulting in blurred graphs.
> This removes the padding and shows the graphs in full size.
>=20
> Fixes: #12657
>=20
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/html/themes/ipfire/include/css/style.css | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/html/html/themes/ipfire/include/css/style.css b/html/html/them=
es/ipfire/include/css/style.css
> index 2c727a770..b92f476c4 100644
> --- a/html/html/themes/ipfire/include/css/style.css
> +++ b/html/html/themes/ipfire/include/css/style.css
> @@ -359,7 +359,7 @@ div.rrdimage > ul {
> }
>=20
> div.rrdimage > img {
> -	box-sizing: border-box;
> +	padding: 0;
> 	max-width: 100%;
> 	min-height: 290px;
> }
> --=20
> 2.27.0.windows.1
>=20


--===============5918227174699871618==--