[PATCH] strongswan: Update to 5.9.0

[PATCH] strongswan: Update to 5.9.0

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

- Update strongswan from version 5.8.4 to 5.9.0
  see https://wiki.strongswan.org/versions/78

Supporting request from Peter Müller
Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com

---
 lfs/strongswan | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lfs/strongswan b/lfs/strongswan
index 3be90db9a..d62a37c81 100644
--- a/lfs/strongswan
+++ b/lfs/strongswan
@@ -24,7 +24,7 @@
 
 include Config
 
-VER        = 5.8.4
+VER        = 5.9.0
 
 THISAPP    = strongswan-$(VER)
 DL_FILE    = $(THISAPP).tar.bz2
@@ -40,7 +40,7 @@ objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = 0634e7f40591bd3f6770e583c3f27d29
+$(DL_FILE)_MD5 = 705628cddd5b7683ef8a688acd9514d8
 
 install : $(TARGET)
 
-- 
2.28.0

Re: [PATCH] strongswan: Update to 5.9.0

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

Hi,

> On 2 Sep 2020, at 09:36, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
> 
> - Update strongswan from version 5.8.4 to 5.9.0
>  see https://wiki.strongswan.org/versions/78
> 
> Supporting request from Peter Müller
> Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com

This is a slightly invalid email address.

You can simply run “git commit -s” and it will automatically add that line for you, so that you don’t have to worry about it any more.

Apart from that, the patch looks good. Did you check for any rootfile changes?

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

Best,
-Michael

> 
> ---
> lfs/strongswan | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/strongswan b/lfs/strongswan
> index 3be90db9a..d62a37c81 100644
> --- a/lfs/strongswan
> +++ b/lfs/strongswan
> @@ -24,7 +24,7 @@
> 
> include Config
> 
> -VER        = 5.8.4
> +VER        = 5.9.0
> 
> THISAPP    = strongswan-$(VER)
> DL_FILE    = $(THISAPP).tar.bz2
> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_MD5 = 0634e7f40591bd3f6770e583c3f27d29
> +$(DL_FILE)_MD5 = 705628cddd5b7683ef8a688acd9514d8
> 
> install : $(TARGET)
> 
> -- 
> 2.28.0
> 

Re: [PATCH] strongswan: Update to 5.9.0

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]

Hi Michael,

Sorry for the error with the email address. Yes that was finger trouble. The first @ should have been a .

Unfortunately I then copy/pasted that into the postfix patch, so that has the same error.

Didn't know about the "git commit -s" option. Will remember that for the future.


Regarding the rootfiles, I must admit I didn't look at them, for strongswan or postfix, because the build didn't highlight that there was a difference that needed to be resolved. I had assumed that if the build didn't highlight anything then the rootfiles were the same.

For future builds I will explicitly check if there is any difference in the rootfiles.

I will also go back and check for strongswan and postfix and report back if there is any difference requiring me to redo the patches.

Regards,

Adolf

On 02/09/2020 15:29, Michael Tremer wrote:
> Hi,
>
>> On 2 Sep 2020, at 09:36, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>
>> - Update strongswan from version 5.8.4 to 5.9.0
>>   see https://wiki.strongswan.org/versions/78
>>
>> Supporting request from Peter Müller
>> Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com
> This is a slightly invalid email address.
>
> You can simply run “git commit -s” and it will automatically add that line for you, so that you don’t have to worry about it any more.
>
> Apart from that, the patch looks good. Did you check for any rootfile changes?
>
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>
> Best,
> -Michael
>
>> ---
>> lfs/strongswan | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lfs/strongswan b/lfs/strongswan
>> index 3be90db9a..d62a37c81 100644
>> --- a/lfs/strongswan
>> +++ b/lfs/strongswan
>> @@ -24,7 +24,7 @@
>>
>> include Config
>>
>> -VER        = 5.8.4
>> +VER        = 5.9.0
>>
>> THISAPP    = strongswan-$(VER)
>> DL_FILE    = $(THISAPP).tar.bz2
>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>
>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>
>> -$(DL_FILE)_MD5 = 0634e7f40591bd3f6770e583c3f27d29
>> +$(DL_FILE)_MD5 = 705628cddd5b7683ef8a688acd9514d8
>>
>> install : $(TARGET)
>>
>> -- 
>> 2.28.0
>>

Re: [PATCH] strongswan: Update to 5.9.0

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 2605 bytes --]

Hallo Michael,

I have rerun the builds of strongswan and postfix and run a diff on the previous rootfiles and the ones generated from the builds in the log directory. In both cases there were no differences so I can confirm no change in the rootfiles.

Regards,

Adolf.


On 02/09/2020 15:52, Adolf Belka wrote:
> Hi Michael,
>
> Sorry for the error with the email address. Yes that was finger trouble. The first @ should have been a .
>
> Unfortunately I then copy/pasted that into the postfix patch, so that has the same error.
>
> Didn't know about the "git commit -s" option. Will remember that for the future.
>
>
> Regarding the rootfiles, I must admit I didn't look at them, for strongswan or postfix, because the build didn't highlight that there was a difference that needed to be resolved. I had assumed that if the build didn't highlight anything then the rootfiles were the same.
>
> For future builds I will explicitly check if there is any difference in the rootfiles.
>
> I will also go back and check for strongswan and postfix and report back if there is any difference requiring me to redo the patches.
>
> Regards,
>
> Adolf
>
> On 02/09/2020 15:29, Michael Tremer wrote:
>> Hi,
>>
>>> On 2 Sep 2020, at 09:36, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>>
>>> - Update strongswan from version 5.8.4 to 5.9.0
>>>   see https://wiki.strongswan.org/versions/78
>>>
>>> Supporting request from Peter Müller
>>> Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com
>> This is a slightly invalid email address.
>>
>> You can simply run “git commit -s” and it will automatically add that line for you, so that you don’t have to worry about it any more.
>>
>> Apart from that, the patch looks good. Did you check for any rootfile changes?
>>
>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>
>> Best,
>> -Michael
>>
>>> ---
>>> lfs/strongswan | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/lfs/strongswan b/lfs/strongswan
>>> index 3be90db9a..d62a37c81 100644
>>> --- a/lfs/strongswan
>>> +++ b/lfs/strongswan
>>> @@ -24,7 +24,7 @@
>>>
>>> include Config
>>>
>>> -VER        = 5.8.4
>>> +VER        = 5.9.0
>>>
>>> THISAPP    = strongswan-$(VER)
>>> DL_FILE    = $(THISAPP).tar.bz2
>>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>>
>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>>
>>> -$(DL_FILE)_MD5 = 0634e7f40591bd3f6770e583c3f27d29
>>> +$(DL_FILE)_MD5 = 705628cddd5b7683ef8a688acd9514d8
>>>
>>> install : $(TARGET)
>>>
>>> -- 
>>> 2.28.0
>>>

Re: [PATCH] strongswan: Update to 5.9.0

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2470 bytes --]

Hi,

> On 2 Sep 2020, at 14:52, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
> 
> Hi Michael,
> 
> Sorry for the error with the email address. Yes that was finger trouble. The first @ should have been a .

No problems. You should see what BS I have committed over the years…

> Unfortunately I then copy/pasted that into the postfix patch, so that has the same error.
> 
> Didn't know about the "git commit -s" option. Will remember that for the future.
> 
> 
> Regarding the rootfiles, I must admit I didn't look at them, for strongswan or postfix, because the build didn't highlight that there was a difference that needed to be resolved. I had assumed that if the build didn't highlight anything then the rootfiles were the same.
> 
> For future builds I will explicitly check if there is any difference in the rootfiles.

Yes, please.

> I will also go back and check for strongswan and postfix and report back if there is any difference requiring me to redo the patches.

Thank you.

> Regards,
> 
> Adolf
> 
> On 02/09/2020 15:29, Michael Tremer wrote:
>> Hi,
>> 
>>> On 2 Sep 2020, at 09:36, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>> 
>>> - Update strongswan from version 5.8.4 to 5.9.0
>>>  see https://wiki.strongswan.org/versions/78
>>> 
>>> Supporting request from Peter Müller
>>> Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com
>> This is a slightly invalid email address.
>> 
>> You can simply run “git commit -s” and it will automatically add that line for you, so that you don’t have to worry about it any more.
>> 
>> Apart from that, the patch looks good. Did you check for any rootfile changes?
>> 
>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>> 
>> Best,
>> -Michael
>> 
>>> ---
>>> lfs/strongswan | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/lfs/strongswan b/lfs/strongswan
>>> index 3be90db9a..d62a37c81 100644
>>> --- a/lfs/strongswan
>>> +++ b/lfs/strongswan
>>> @@ -24,7 +24,7 @@
>>> 
>>> include Config
>>> 
>>> -VER        = 5.8.4
>>> +VER        = 5.9.0
>>> 
>>> THISAPP    = strongswan-$(VER)
>>> DL_FILE    = $(THISAPP).tar.bz2
>>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>> 
>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>> 
>>> -$(DL_FILE)_MD5 = 0634e7f40591bd3f6770e583c3f27d29
>>> +$(DL_FILE)_MD5 = 705628cddd5b7683ef8a688acd9514d8
>>> 
>>> install : $(TARGET)
>>> 
>>> -- 
>>> 2.28.0
>>>