From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] strongswan: Update to 5.9.0
Date: Fri, 04 Sep 2020 16:47:14 +0100
Message-ID: <6B5DD5E0-F367-4F9D-AAC7-9B380466EE88@ipfire.org>
In-Reply-To: <de1115c7-1291-4be6-5a56-3a675813db5c@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7779822036604584222=="
List-Id: <development.lists.ipfire.org>

--===============7779822036604584222==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 2 Sep 2020, at 14:52, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>=20
> Hi Michael,
>=20
> Sorry for the error with the email address. Yes that was finger trouble. Th=
e first @ should have been a .

No problems. You should see what BS I have committed over the years=E2=80=A6

> Unfortunately I then copy/pasted that into the postfix patch, so that has t=
he same error.
>=20
> Didn't know about the "git commit -s" option. Will remember that for the fu=
ture.
>=20
>=20
> Regarding the rootfiles, I must admit I didn't look at them, for strongswan=
 or postfix, because the build didn't highlight that there was a difference t=
hat needed to be resolved. I had assumed that if the build didn't highlight a=
nything then the rootfiles were the same.
>=20
> For future builds I will explicitly check if there is any difference in the=
 rootfiles.

Yes, please.

> I will also go back and check for strongswan and postfix and report back if=
 there is any difference requiring me to redo the patches.

Thank you.

> Regards,
>=20
> Adolf
>=20
> On 02/09/2020 15:29, Michael Tremer wrote:
>> Hi,
>>=20
>>> On 2 Sep 2020, at 09:36, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>>=20
>>> - Update strongswan from version 5.8.4 to 5.9.0
>>>  see https://wiki.strongswan.org/versions/78
>>>=20
>>> Supporting request from Peter M=C3=BCller
>>> Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com
>> This is a slightly invalid email address.
>>=20
>> You can simply run =E2=80=9Cgit commit -s=E2=80=9D and it will automatical=
ly add that line for you, so that you don=E2=80=99t have to worry about it an=
y more.
>>=20
>> Apart from that, the patch looks good. Did you check for any rootfile chan=
ges?
>>=20
>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>=20
>> Best,
>> -Michael
>>=20
>>> ---
>>> lfs/strongswan | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>=20
>>> diff --git a/lfs/strongswan b/lfs/strongswan
>>> index 3be90db9a..d62a37c81 100644
>>> --- a/lfs/strongswan
>>> +++ b/lfs/strongswan
>>> @@ -24,7 +24,7 @@
>>>=20
>>> include Config
>>>=20
>>> -VER        =3D 5.8.4
>>> +VER        =3D 5.9.0
>>>=20
>>> THISAPP    =3D strongswan-$(VER)
>>> DL_FILE    =3D $(THISAPP).tar.bz2
>>> @@ -40,7 +40,7 @@ objects =3D $(DL_FILE)
>>>=20
>>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>>=20
>>> -$(DL_FILE)_MD5 =3D 0634e7f40591bd3f6770e583c3f27d29
>>> +$(DL_FILE)_MD5 =3D 705628cddd5b7683ef8a688acd9514d8
>>>=20
>>> install : $(TARGET)
>>>=20
>>> --=20
>>> 2.28.0
>>>=20


--===============7779822036604584222==--