public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vnstat 2.6: Fix for lfs
Date: Sat, 11 Apr 2020 16:28:58 +0100	[thread overview]
Message-ID: <6DC696D3-1EF1-486C-A223-983C302C28AD@ipfire.org> (raw)
In-Reply-To: <20200411143848.23912-1-matthias.fischer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

Hello,

Thanks for the patch, but this only solves one of my concerns.

What about printing the colourful exit status more than once?

Best,
-Michael

> On 11 Apr 2020, at 15:38, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Removed 'sleep 2'
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> src/initscripts/system/vnstat | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/src/initscripts/system/vnstat b/src/initscripts/system/vnstat
> index bcc19c3ab..a21905d75 100755
> --- a/src/initscripts/system/vnstat
> +++ b/src/initscripts/system/vnstat
> @@ -20,14 +20,12 @@ case "$1" in
> 
> 		boot_mesg "Starting vnstatd..."
> 		loadproc /usr/sbin/vnstatd -d --alwaysadd
> -		sleep 2
> 		evaluate_retval
> 		;;
> 
> 	stop)
> 		boot_mesg "Stopping vnstatd..."
> 		killproc /usr/sbin/vnstatd
> -		sleep 2
> 		evaluate_retval
> 
> 		umount_ramdisk "${VNSTATLOG}"
> -- 
> 2.18.0
> 


  reply	other threads:[~2020-04-11 15:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-11 14:38 Matthias Fischer
2020-04-11 15:28 ` Michael Tremer [this message]
2020-04-11 16:39   ` Matthias Fischer
2020-04-11 18:03     ` Michael Tremer
2020-04-11 18:17       ` Matthias Fischer
2020-04-11 18:21         ` Michael Tremer
2020-04-11 18:40           ` Matthias Fischer
2020-04-11 18:22       ` Matthias Fischer
2020-04-11 18:26         ` Michael Tremer
2020-04-11 18:41           ` Matthias Fischer
2020-04-12 14:15             ` Michael Tremer
2020-04-12 17:22               ` Matthias Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6DC696D3-1EF1-486C-A223-983C302C28AD@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox