From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vnstat 2.6: Fix for lfs
Date: Sat, 11 Apr 2020 16:28:58 +0100
Message-ID: <6DC696D3-1EF1-486C-A223-983C302C28AD@ipfire.org>
In-Reply-To: <20200411143848.23912-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6473415029715889931=="
List-Id: <development.lists.ipfire.org>

--===============6473415029715889931==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Thanks for the patch, but this only solves one of my concerns.

What about printing the colourful exit status more than once?

Best,
-Michael

> On 11 Apr 2020, at 15:38, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Removed 'sleep 2'
>=20
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> src/initscripts/system/vnstat | 2 --
> 1 file changed, 2 deletions(-)
>=20
> diff --git a/src/initscripts/system/vnstat b/src/initscripts/system/vnstat
> index bcc19c3ab..a21905d75 100755
> --- a/src/initscripts/system/vnstat
> +++ b/src/initscripts/system/vnstat
> @@ -20,14 +20,12 @@ case "$1" in
>=20
> 		boot_mesg "Starting vnstatd..."
> 		loadproc /usr/sbin/vnstatd -d --alwaysadd
> -		sleep 2
> 		evaluate_retval
> 		;;
>=20
> 	stop)
> 		boot_mesg "Stopping vnstatd..."
> 		killproc /usr/sbin/vnstatd
> -		sleep 2
> 		evaluate_retval
>=20
> 		umount_ramdisk "${VNSTATLOG}"
> --=20
> 2.18.0
>=20


--===============6473415029715889931==--