From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 40/50] gcc: Compile without ZSTD
Date: Wed, 23 Feb 2022 09:45:44 +0000
Message-ID: <6E8123C8-D812-44C4-9A5C-35AD2FFBA05D@ipfire.org>
In-Reply-To: <20220222125135.1211290-41-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8549771006830791762=="
List-Id: <development.lists.ipfire.org>

--===============8549771006830791762==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Peter,

Could you please revert this patch again?

Bird seems to (unconditionally) enable LTO which it shouldn=E2=80=99t. This p=
atch shouldn=E2=80=99t break LTO at all, but it does.

Since this is not a priority right now, could you please just revert this pat=
ch?

-Michael

> On 22 Feb 2022, at 12:51, Michael Tremer <michael.tremer(a)ipfire.org> wrot=
e:
>=20
> GCC can use ZSTD to compress debugging/LTO information in binary
> objects. However, on riscv64, compiling zstd requires libatomic which is
> not available at this point.
>=20
> In order to make the build work, we explicitely disable ZSTD in GCC and
> build ZSTD after libatomic is available.
>=20
> Although ZSTD offers great compression, we won't have any disadvantages
> through this change since we do not ship any debugging information and
> at this point in time to not use LTO.
>=20
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> lfs/gcc | 3 ++-
> make.sh | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/lfs/gcc b/lfs/gcc
> index f78891e24..563e94c16 100644
> --- a/lfs/gcc
> +++ b/lfs/gcc
> @@ -182,7 +182,8 @@ EXTRA_CONFIG +=3D \
> 	--disable-multilib \
> 	--with-bugurl=3Dhttps://bugzilla.ipfire.org \
> 	--disable-libunwind-exceptions \
> -	--enable-gnu-unique-object
> +	--enable-gnu-unique-object \
> +	--without-zstd
>=20
> export XCFLAGS =3D $(CFLAGS)
> export TCFLAGS =3D $(CFLAGS)
> diff --git a/make.sh b/make.sh
> index cb11b36ab..522fe8401 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1079,7 +1079,6 @@ buildbase() {
> 	lfsmake2 tzdata
> 	lfsmake2 cleanup-toolchain
> 	lfsmake2 zlib
> -	lfsmake2 zstd
> 	lfsmake2 autoconf
> 	lfsmake2 automake
> 	lfsmake2 libtool
> @@ -1090,6 +1089,7 @@ buildbase() {
> 	lfsmake2 libxcrypt
> 	lfsmake2 file
> 	lfsmake2 gcc
> +	lfsmake2 zstd
> 	lfsmake2 sed
> 	lfsmake2 berkeley
> 	lfsmake2 coreutils
> --=20
> 2.30.2
>=20


--===============8549771006830791762==--