Re: [PATCH] Remove space after every 80 characters in WebGUI "Logs/System Logs".

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

Hello Stephen,

Welcome to the list!

> On 5 Aug 2024, at 19:47, Stephen Cuka <stephen(a)firemypi.org> wrote:
> 
> Hi Adolf,
> 
> Thanks for your help on this.
> 
> I left the original code lines in place for context.  They're not really necessary.  If it's better, I can remove them and resubmit the patch.
> 
> For the 
> 
> my $d = $2.': '.$data;
> 
> suggestion, there is some special processing for the display for the RED section logs.
> 
>        # correct the cut position, just when section=RED
>        if (($cgiparams{'SECTION'} eq 'red' ) && ($sec =~ /(kernel:)(.*)/)) {
>            $sec = 'kernel';
>            $data = $2.': '.$data;
>        }
> 
> Using 'my $d = $2. ': ' .$data;' for everything would add the timestamp to the front of the log text displayed for all sections.
> 
> I'm not sure if the special processing for $data for RED is necessary.  I think that the point of the 'if' statement is to clean up the Section display for entries from 'kernel: ippp\d' and 'kernel: isdn.*' matches for RED, but I don't know why adding the timestamp to the front of data would be desirable in that specific case.  I don't have any log entries to reference for that though.

I think we can safely drop this as we no longer support ISDN.

-Michael

> Thanks,
> Stephen