From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Remove space after every 80 characters in WebGUI
 "Logs/System Logs".
Date: Tue, 06 Aug 2024 16:59:35 +0100
Message-ID: <6EDAC14D-5A11-4520-8379-EA6249DDAA83@ipfire.org>
In-Reply-To: <172288367319.1831417.3462292333355828565@mail02.haj.ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2741153627002079446=="
List-Id: <development.lists.ipfire.org>

--===============2741153627002079446==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Stephen,

Welcome to the list!

> On 5 Aug 2024, at 19:47, Stephen Cuka <stephen(a)firemypi.org> wrote:
>=20
> Hi Adolf,
>=20
> Thanks for your help on this.
>=20
> I left the original code lines in place for context.  They're not really ne=
cessary.  If it's better, I can remove them and resubmit the patch.
>=20
> For the=20
>=20
> my $d =3D $2.': '.$data;
>=20
> suggestion, there is some special processing for the display for the RED se=
ction logs.
>=20
>        # correct the cut position, just when section=3DRED
>        if (($cgiparams{'SECTION'} eq 'red' ) && ($sec =3D~ /(kernel:)(.*)/)=
) {
>            $sec =3D 'kernel';
>            $data =3D $2.': '.$data;
>        }
>=20
> Using 'my $d =3D $2. ': ' .$data;' for everything would add the timestamp t=
o the front of the log text displayed for all sections.
>=20
> I'm not sure if the special processing for $data for RED is necessary.  I t=
hink that the point of the 'if' statement is to clean up the Section display =
for entries from 'kernel: ippp\d' and 'kernel: isdn.*' matches for RED, but I=
 don't know why adding the timestamp to the front of data would be desirable =
in that specific case.  I don't have any log entries to reference for that th=
ough.

I think we can safely drop this as we no longer support ISDN.

-Michael

> Thanks,
> Stephen


--===============2741153627002079446==--